From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rWtKGZ1hR2dj+QEAWB0awg (envelope-from ) for ; Wed, 27 Nov 2024 13:14:53 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Tq8abnlb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 47F311E097; Wed, 27 Nov 2024 13:14:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 50FCF1E05C for ; Wed, 27 Nov 2024 13:14:52 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B2F1B385840A for ; Wed, 27 Nov 2024 18:14:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2F1B385840A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Tq8abnlb Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 216973858CDB for ; Wed, 27 Nov 2024 18:14:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 216973858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 216973858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732731250; cv=none; b=sQREgVXNMqr3aMsZpd3JePrmnn/GFfxCAi7I9hp2/f4KNS5LaEIqMZCvUZ5uJd+7IvTsdzNtSUCkB5Ob/eTAcKPkDpXhifP1rAjBEKvm6xz4NJcyJb9MhnWgyayHpk8IkFCOUklXiUj+mDEPmm+G8XCdxVwtmmjbkC4+d4rSO8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732731250; c=relaxed/simple; bh=6S2UYmMr3k5SXkq39XcKX2ksAY3RsO1MmJ6nKwUSkSo=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=tD7tv8HKjIP+76ucFXiEpwzzExWIxtQt259XpTWHjHIuH/C3LQu2KjyrXPr4dFBS21RPVDAdBMBs7tPeJk4e45DbcqNzmgobR9JyIS/XivR+QQdXBj3iJjEtExRl8d+4y+ubwspjBbXhDtUEJfQ2x7Ax0erTQ2VgK6F3upOF4Lc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 216973858CDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732731249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mjuTTQSm4rXlBEdO56HgqUVX4wU0Guj0Fr4VwEckmlU=; b=Tq8abnlbt4mfJ9q09v5WacnLKAmkeVLHtIF4JK0M6EZ4kNZ3eA3M7oYr4PY78hj/2nYYQj 8mnt8A7E9YH9+ESlKGmmesIKsokSMPwTW0ozWusQHuT/CMdzsv9LhTqXg8IDOBTlvQGPqK FwhXAIadj30rSm4YiT2jNSeh/SSXI3E= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-yrt9GSjOOx2bJ5K83XXLZA-1; Wed, 27 Nov 2024 13:14:08 -0500 X-MC-Unique: yrt9GSjOOx2bJ5K83XXLZA-1 X-Mimecast-MFC-AGG-ID: yrt9GSjOOx2bJ5K83XXLZA Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C42521955E9C for ; Wed, 27 Nov 2024 18:14:07 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.80.92]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EC290300019E; Wed, 27 Nov 2024 18:14:06 +0000 (UTC) Date: Wed, 27 Nov 2024 11:14:02 -0700 From: Kevin Buettner To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: skip gdb.threads/omp-par-scope.exp with clang Message-ID: <20241127111402.048359b9@f40-zbm-amd> In-Reply-To: <20241125184225.1021664-1-guinevere@redhat.com> References: <20241125184225.1021664-1-guinevere@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 71H7telCpOOViUI1twwq2E7xt2V_49yJM_nKNub604c_1732731247 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, 25 Nov 2024 15:42:25 -0300 Guinevere Larsen wrote: > Since 2020 it has been reported to clang[1] that the debug information > around OpenMP is insufficient. The OpenMP section is not declared > within the correct scope, and instead clang marks as if the section was > a function in the global scope. This causes several failures in the > test gdb.threads/omp-par-scope.exp when using clang to test GDB. > > Since this isn't a true failure of GDB, and there is little expectation > that clang will be able to fix this soon, this commit disables the > aforementioned test when clang is being used. > > [1] https://github.com/llvm/llvm-project/issues/44236 I thought at first that it might make sense to XFAIL the problematic tests. But after running it for myself, I see that clang has so many problems that I now agree that it makes sense to disable the test entirely (for clang). One nit though... > +if { [test_compiler_info "clang*"] } { > + # Clang doesn't add OpenMP information in the correct scope, > + # so all relevant tests here will fail. See here for more info: > + # https://github.com/llvm/llvm-project/issues/44236 > + unsupported "Clang doesn't add required info for the test" Could you change the message to: "Clang doesn't provided the required debuginfo for this test" ? > + return > +} > + With that nit fixed... Approved-by: Kevin Buettner