From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id x8cWEFH5N2dufjMAWB0awg (envelope-from ) for ; Fri, 15 Nov 2024 20:45:53 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oGob8ioI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2DF9D1E1A8; Fri, 15 Nov 2024 20:45:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 30BBB1E1A6 for ; Fri, 15 Nov 2024 20:45:52 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9CC143858290 for ; Sat, 16 Nov 2024 01:45:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9CC143858290 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oGob8ioI Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id D7AD23858C31 for ; Sat, 16 Nov 2024 01:44:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D7AD23858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D7AD23858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731721478; cv=none; b=ISKlYsZ7fHue6QCL5sh6C9f4OKQG2WDBPFFeNAbZme6GO89NUGn7e4Np2TdSntoSMBrUTno7B8bPSfcQ8MHbYVcqvjCdNuqOpxdoTJdMt9LE7Bo4WYXQOSWuOqEotyyPiyx5UW+lRijNl5dduHjtr5ciNkK8F3KC00Lhqk+RBgI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731721478; c=relaxed/simple; bh=3qkH7ZQxQ2OLUt5D/jYydFT0sVTOcXIvW6OY1aG13u0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=gYJDCXonDqtfAsz/WaNw4ix4F7DcLHeyGtjLNf22h2XrkErSgxQoUmKExImyoL09jbfCFKO8EKpksAEo/6IRwHFjC1ECoA9VrWEtcsqOUukKR6rId8GYBAmjv7e1mvMAZl4JScCwBBhvsX86NypvNsygIbJGYgPh3TVQawA8vEE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7AD23858C31 Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id BzcvtVNSDiA19C7rZtjyDH; Sat, 16 Nov 2024 01:44:37 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id C7rYtnQSO2Zy0C7rYtPtYR; Sat, 16 Nov 2024 01:44:36 +0000 X-Authority-Analysis: v=2.4 cv=Q4EZ4J2a c=1 sm=1 tr=0 ts=6737f904 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VlfZXiiP6vEA:10 a=ItBw4LHWJt0A:10 a=piFPDUMi-P1kftT7ETgA:9 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kIxdGgdKDl+hIT3SddIxKOBJlH1iKScm9UADBMcBaRQ=; b=oGob8ioI42DoRCWNdWa2RwaDKT 3GyUuPZ8pA2y1c9zSC2FDx1oaEhDomznFPdHtqOsnA9m1waZtHVWH9paVriLybny4X/OskbHxHRbY bzRR7RI6ikixvFVUHZoroiMS7; Received: from 97-122-113-155.hlrn.qwest.net ([97.122.113.155]:40350 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tC7rX-002ZbT-2R; Fri, 15 Nov 2024 18:44:35 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Use bool for solib::symbols_loaded Date: Fri, 15 Nov 2024 18:44:29 -0700 Message-ID: <20241116014429.1628623-1-tom@tromey.com> X-Mailer: git-send-email 2.46.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.113.155 X-Source-L: No X-Exim-ID: 1tC7rX-002ZbT-2R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-113-155.hlrn.qwest.net (localhost.localdomain) [97.122.113.155]:40350 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDGUMZJtu25UfNqTUDBMmGQZnJFpuQYf+9AwGJ7fCdpEd3hfOncbofHwXZu8PHiefheoX2dnkaygdRdgh4o4z/M68NeK3lezIfrfQA+ng5WonBxU6y0A O9eR2/Cv+CyK3HUN7r+kSvTzkbPPRWgxORvNeouGNhuof+c14vAP0ij/6rtUJgKs2XwcGF48ifq81cPp8IKxXk1G2huSNG+74Ug= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This changes solib::symbols_loaded to be of type 'bool'. --- gdb/solib.c | 6 +++--- gdb/solist.h | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/solib.c b/gdb/solib.c index dfcee4309bd..fdefdf0b142 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -593,7 +593,7 @@ solib::clear () this->abfd = nullptr; /* Our caller closed the objfile, possibly via objfile_purge_solibs. */ - this->symbols_loaded = 0; + this->symbols_loaded = false; this->objfile = nullptr; this->addr_low = this->addr_high = 0; @@ -653,7 +653,7 @@ solib_read_symbols (solib &so, symfile_add_flags flags) so.objfile->addr_low = so.addr_low; } - so.symbols_loaded = 1; + so.symbols_loaded = true; } catch (const gdb_exception_error &e) { @@ -1259,7 +1259,7 @@ reload_shared_libraries_1 (int from_tty) for (solib &so : current_program_space->solibs ()) { const char *found_pathname = NULL; - bool was_loaded = so.symbols_loaded != 0; + bool was_loaded = so.symbols_loaded; symfile_add_flags add_flags = SYMFILE_DEFER_BP_RESET; if (from_tty) diff --git a/gdb/solist.h b/gdb/solist.h index 336bb011b2e..8ad0aefd9e3 100644 --- a/gdb/solist.h +++ b/gdb/solist.h @@ -77,7 +77,9 @@ struct solib : intrusive_list_node current_sos must initialize these fields to 0. */ gdb_bfd_ref_ptr abfd; - char symbols_loaded = 0; /* flag: symbols read in yet? */ + + /* True if symbols have been read in. */ + bool symbols_loaded = false; /* objfile with symbols for a loaded library. Target memory is read from ABFD. OBJFILE may be NULL either before symbols have been loaded, if -- 2.46.1