From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kYx4M2i8K2cc6ycAWB0awg (envelope-from ) for ; Wed, 06 Nov 2024 13:58:48 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BAJzRt0h; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9DB0D1E0C0; Wed, 6 Nov 2024 13:58:48 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 605181E0C0 for ; Wed, 6 Nov 2024 13:58:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E7A503858D34 for ; Wed, 6 Nov 2024 18:58:46 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8AFB13858D20 for ; Wed, 6 Nov 2024 18:58:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AFB13858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8AFB13858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730919509; cv=none; b=ZA/rh1sOJjz+/S0kroJ5OfrJY3E/ozok6RYpW34WbPv4VeQ2glbSW7IP3XHQgJWR4n+l6SWDxmHNK470GTekOuX/wEG0qouoqYOWEYA+pXvRbGZ4n/SDAMOlp+jJrXvWIulPMfVVdqfFwQYZ18rcksKzVPwFx6LhvMZxAh0kr9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730919509; c=relaxed/simple; bh=SmTvClpQjBmD//Yo3+gMA/+xhItGfTccLt3qU4pUKZo=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=JjXwCHMD7KUEw/bpkMh4haglAUNX7CzVIdB4xEdUe6voxeyDJkJqcBRgdxcrinnYDEgSc10/IXUVkHGVo8uTTnGjksRQ/YT8QgaEQWXdItOlHxBIo/4nxaQXtkbMoSYkTMqaZf6za20yC6vgj61NCNX7V5w3nX1HGzfA2DjH1N8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730919505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DlZoWfoGLQUfxWQrGq7i8KPgRqOEmmEGvOeE3/B3kkE=; b=BAJzRt0hcyz80ZXzZOoykUyc5H+cACrJG4TRtEGssfMMSAq4f/eKfCKWAuIYE16pMAX28R St3UcKb/fQDZyiF7Jjoosn0Ob5ILgtgwkSKK3U14qAjcascCeFgdw2Ag/tgR6OoNWXcFN1 RPDalcGFmkhamM7SOTgKkUh50pg374Q= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-V28Z-XjiOwqh5kvSBm0I4g-1; Wed, 06 Nov 2024 13:58:24 -0500 X-MC-Unique: V28Z-XjiOwqh5kvSBm0I4g-1 X-Mimecast-MFC-AGG-ID: V28Z-XjiOwqh5kvSBm0I4g Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7C5F41955D9D for ; Wed, 6 Nov 2024 18:58:23 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.81.112]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 85F821955F41; Wed, 6 Nov 2024 18:58:22 +0000 (UTC) Date: Wed, 6 Nov 2024 11:58:18 -0700 From: Kevin Buettner To: Alexandra =?ISO-8859-1?Q?H=E1jkov=E1?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add dw2-aranges.exp Message-ID: <20241106115712.2df7e54f@f40-zbm-amd> In-Reply-To: <20241106163255.2619114-1-ahajkova@redhat.com> References: <20241106163255.2619114-1-ahajkova@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3AUxMXlg5Xysum568OpYlFKiYXyDKRfy5q8Ax2yYldw_1730919503 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Sasha, The actual patches in this commit LGTM (once Keith's concern is addressed), but I'd like to see some changes to the commit log... > This test tests GDB is able to load a file with the > .debug_aranges section Address size set to 0. Maybe say: This test checks that GDB is able to load DWARF information when .debug_aranges has a section address size that is set to 0. > The test was originally written by Jan Kratochvil to test > commit 927aa2e778dce440f4de5de8fc37ead1683a804e > Author: Jan Kratochvil > Date: Fri Dec 8 22:44:12 2017 +0000 > > DWARF-5: .debug_names index consumer I think that this can be written more compactly, perhaps like this: This test was originally written by Jan Kratochvil to test commit 927aa2e778d from 2017, titled "DWARF-5: .debug_names index consumer". > The test was passing from the beginning. > This test has been living in the Fedora tree > for a long time, it seems to be a reasonable > some bad debug information. Maybe change this to: This test was originally written using a static .S file and has been present in the Fedora tree for a long time. > If dwarf2/aranges.c is modified to turn off the > address_size check, GDB will crash with SIGPE s/SIGPE/SIGFPE/ (I think.) > when loading the executable with the address size s/the address/address/ > set to zero. > > I modified the DWARF assembler to make it possible > to set the Addres size to zero in a .debug_aranges section s/Addres/address/ > and used a DWARF assembler to produce the assembly file. s/a DWARF/the DWARF/ With those changes (assuming you're okay with them) and with Keith's change to use "require dwarf2_support",... Approved-by: Kevin Buettner