From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id u7HDODJ5GWdPaxgAWB0awg (envelope-from ) for ; Wed, 23 Oct 2024 18:31:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FNNO973M; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D58A31E37C; Wed, 23 Oct 2024 18:31:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 553C61E37A for ; Wed, 23 Oct 2024 18:31:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DEB993858C5F for ; Wed, 23 Oct 2024 22:31:13 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 9C5553858D21 for ; Wed, 23 Oct 2024 22:30:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C5553858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9C5553858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729722653; cv=none; b=OYGgrraRUPmZLS9rKOpUTqSjVqsznverZHUVSBfXlDBK6KyeiWrnDrXVIqCz1i+Sm/qvzEPLjuCcdjWyqOeCFPgUEh6LKNM7wiNhhWiL6IiQevWMU3pNuVxhUaPGpBZVGSKljih7ey8WvXXj7ON9nvFeM5OMCFpnAoWx1M9aD9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729722653; c=relaxed/simple; bh=owytmww9CoH2RaYdsU/LtTHYVkhtOOpiW4UFktIGpqk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=sWZv+WnhFdkihXVZdiUHaGbZeZ1sRsAJbgzXSDRtjn7E4qKKc/mlgMEAoFzsG4oSiMDCMomhVv1P9L7KKxGW1tuJ4wmSOl83Yr7Kb2wOirKzt+6uuEBhDO6Ubl4v7DhQChHzKW7y+Chxhww2JXneMQzmYOyLpcHp8XoLB44kb80= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729722652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XWRDQeCi4dWsAMdJZbNmo+t7nhnf1o6nVjDsR5YWlDM=; b=FNNO973MNSjMBoxG9nTLPOy+OXoKjSUKYxMHo4tryY0+giyY3vTQSrOHd+3gOqSbmHX4fh vyQvXqXTlM7Bwm+USHxKtRZCDeQdnUseRIu8BqW7fy565lHDFNS6KcMaOB0SoZc6812aeq Il0MO23LcQUGSlhCEAi2k2orVfkm/6s= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-tAuQzTQeOC2hJ7Ruz5_9ag-1; Wed, 23 Oct 2024 18:30:49 -0400 X-MC-Unique: tAuQzTQeOC2hJ7Ruz5_9ag-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2DC1A1956089; Wed, 23 Oct 2024 22:30:48 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.64.38]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C3519300018D; Wed, 23 Oct 2024 22:30:46 +0000 (UTC) Date: Wed, 23 Oct 2024 15:30:43 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/2] Fix a data race with the background DWARF reader Message-ID: <20241023152907.43bd62b0@f40-zbm-amd> In-Reply-To: <20241017-fix-race-pr-symtab-31626-v1-0-3a53459e9651@tromey.com> References: <20241017-fix-race-pr-symtab-31626-v1-0-3a53459e9651@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 17 Oct 2024 18:02:36 -0600 Tom Tromey wrote: > This series fixes a race in the background DWARF reader. > > I was able to reproduce the original race manually (though not via > dejagnu), and then confirmed (at least, there weren't warnings from > TSAN) that this series fixes the problem. > > --- > Tom Tromey (2): > Use gdb_bfd_get_full_section_contents in auto-load.c > Add locking when reading BFD sections > > gdb/auto-load.c | 11 ++++------- > gdb/gdb_bfd.c | 23 +++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 7 deletions(-) > --- > base-commit: 876f0e78ba8244aa5705530fd8522928f05e6783 > change-id: 20241017-fix-race-pr-symtab-31626-e88148cf55a2 > > Best regards, > -- > Tom Tromey > Both patches LGTM. Reviewed-by: Kevin Buettner