From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 80kKBNqbFmdQDxYAWB0awg (envelope-from ) for ; Mon, 21 Oct 2024 14:22:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Rnu9RiNr; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D46D91E360; Mon, 21 Oct 2024 14:22:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A8A131E35E for ; Mon, 21 Oct 2024 14:22:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 43C8B3858C60 for ; Mon, 21 Oct 2024 18:22:16 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A788A3858D20 for ; Mon, 21 Oct 2024 18:21:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A788A3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A788A3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729534918; cv=none; b=YuMjEK9TMyVSgi0MoFS/XOm1moffNS+mCRaE4/WnP5CrTrQLuXbhKCy0vAnebaKNosV4/5+rDu0ipU+EonIauvZ1ECpDqKA4dZJY4GmJ7mjK48jFCcSE/T9jjO/Vru17Ox2lWXDBHROLYW0/v53Y4myX7o5hBFZuEuoVrnx8cYs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729534918; c=relaxed/simple; bh=jm4Gce6+aNPAK0kwY2TVbx7M8+uSRpttNMsDQcKmXZ4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=DhOJSy5THkCXiQz68wbbQCh8nblrVPATZMzVvOTRJ3iqT73foApho4uH3wH4GiKP+Wl6RD7iLWtayMse5+mTTjkAU0AnCZmqtDOIYCqGv3tQEkwZ/49Vj88f4NbYXvsd2rgFiHbRExjp+3fsqrogxRdFaL0zYnkHdcEdFTMISsw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729534915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BqDpXgFAXgVC2veFUr6o8CErtINmd4sCMjhUb6mqERI=; b=Rnu9RiNrQGGgaazlYVgy687m/0hkfzRpxIhFbOfsiARhfsGM8Z5LwSNDVdmWCZYVzTubEb usTqa+L0hl4j32tmS2sYcjcit43tjlcevhtpvrWA79i3wF/SvQVMIjxBXfgL5Ny8G64FHO aazbNKW+SQocDCMOZr2PkWjLwMibTCQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-332-MkmsiVtANeOOh0wbZGTs_Q-1; Mon, 21 Oct 2024 14:21:53 -0400 X-MC-Unique: MkmsiVtANeOOh0wbZGTs_Q-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DE8A219560BD; Mon, 21 Oct 2024 18:21:52 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.80.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 02C2B300018D; Mon, 21 Oct 2024 18:21:51 +0000 (UTC) Date: Mon, 21 Oct 2024 11:21:46 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Pedro Alves Subject: Re: [PATCH v4 0/4] Make linux checkpoints work with multiple inferiors Message-ID: <20241021112146.30146895@f40-zbm-amd> In-Reply-To: <20240626020148.68109-1-kevinb@redhat.com> References: <20240626020148.68109-1-kevinb@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Ping. On Tue, 25 Jun 2024 18:55:51 -0700 Kevin Buettner wrote: > This series fixes some problems with the current checkpoint code. The > first patch makes the checkpoint code inferior aware, fixing a number > of bugs. The second and third patches are largely cosmetic - they > make changes to checkpoint related output. > > The v2 series incorporates Pedro's suggestions regarding the > numbering of checkpoint ids. See the first patch for details. The > tests have been revised to account for these changes and new tests > have been added as well. > > The v3 series splits out a cosmetic change from the first patch. It > capitalizes the output of a successful checkpoint command. This was > prompted by the Linaro regression tester, which, due to the > capitalization change, found two regressions in > gdb.base/kill-during-detach.exp. (I had made a mistake during my own > testing causing this to not be caught.) > > This v4 series addresses Pedro's concerns from his review of the v3 > series. It also adds a NEWS entry and updates the GDB manual with > regard to checkpoint identifiers. > > Kevin Buettner (4): > Make linux checkpoints work with multiple inferiors > Capitalize output of successful checkpoint command > Print only process ptids from linux-fork.c > Linux checkpoints: Update NEWS and gdb.texinfo regarding multiple > inferiors > > gdb/NEWS | 2 + > gdb/doc/gdb.texinfo | 23 +- > gdb/linux-fork.c | 557 +++++++++----- > gdb/linux-fork.h | 15 +- > gdb/linux-nat.c | 18 +- > gdb/testsuite/gdb.base/checkpoint.exp | 26 +- > gdb/testsuite/gdb.base/kill-during-detach.exp | 2 +- > gdb/testsuite/gdb.multi/checkpoint-multi.exp | 689 ++++++++++++++++++ > 8 files changed, 1134 insertions(+), 198 deletions(-) > create mode 100644 gdb/testsuite/gdb.multi/checkpoint-multi.exp > > -- > 2.45.2 >