From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6Lv9KzND/GZv4T0AWB0awg (envelope-from ) for ; Tue, 01 Oct 2024 14:45:07 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JBWw1mPx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AF38D1E353; Tue, 1 Oct 2024 14:45:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B90691E05C for ; Tue, 1 Oct 2024 14:45:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6DD0E3861004 for ; Tue, 1 Oct 2024 18:45:06 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7C7C3385EC15 for ; Tue, 1 Oct 2024 18:43:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C7C3385EC15 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C7C3385EC15 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727808198; cv=none; b=n4g7EQBaq3KLZ/4Uej0ZU+HulkELvMMbHCCIBvn9es2/lnW3zfw6+uBAonxbkuPFzxOSzqpQzW2NlDzqkoXZbZJrq4BX/N1UediZzzn3tl/Nbm9UALQNsh2lXCqTXRmxA5VpO2APBQFYsdWib16MlUzKUSq2vxvsPXJ5v5tc5ao= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727808198; c=relaxed/simple; bh=2leUXR5rsKM4w7jUnRdYjdr8scmczIrcT5Azf7/8oE4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZcUAv/NLdcCAyvhe11qu5w1mCthLATdqIJpHTH1C2beKfhSu/E672M1vOUMY1+84//skOfWxF/gNiYrF3I3jLf6QatEK4mvit8Tg17VHQCNi4F4GwWxi6Ml8OS2eQgZ6Guf1RZbihpLWtELnYtaMCIWm0fFZM4WMYclqohH/J/A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727808193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c7OvXi0I/45pH59yGUBpK+6uXLYWdxDSuZM7ZN1/ulk=; b=JBWw1mPxyXa8mBq345OWIgx99A9crIEDcSjyjVGI/cQQAF991eeq0MrJ8IZ1fkpr0isj/2 weehVMqsWWlu05roTUWvzr2w6QJM/AQM0c7AL4OlcO8+SGHoJRazmdzmy26e1Bw28rVX6Q tpu6en0t1BXrlzlMfvvYD0fjsuUYXLw= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-eQvnovhGMvSkAMaPSHOvBg-1; Tue, 01 Oct 2024 14:43:10 -0400 X-MC-Unique: eQvnovhGMvSkAMaPSHOvBg-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3266F19772CF; Tue, 1 Oct 2024 18:43:09 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.8.191]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7E7AE3003E5F; Tue, 1 Oct 2024 18:43:07 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen , Jan Kratochvil Subject: [PATCH v5 5/5] gdb/testsuite: Test for a backtrace through object without debuginfo Date: Tue, 1 Oct 2024 15:42:35 -0300 Message-ID: <20241001184235.3710608-6-guinevere@redhat.com> In-Reply-To: <20241001184235.3710608-1-guinevere@redhat.com> References: <20241001184235.3710608-1-guinevere@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Guinevere Larsen Fedora has been carrying this test since back in the Project Archer days. A change back then caused GDB to stop being able to backtrace when only some of the object files had debug information. Even though the changed code never seems to have made its way into the main GDB project, I think it makes sense to bring the test along to ensure something like this doesn't pass unnoticed. Co-Authored-By: Jan Kratochvil --- .../backtrace-through-cu-nodebug-caller.c | 28 ++++++ .../backtrace-through-cu-nodebug-main.c | 32 +++++++ .../gdb.base/backtrace-through-cu-nodebug.exp | 90 +++++++++++++++++++ 3 files changed, 150 insertions(+) create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c new file mode 100644 index 00000000000..3a63d72a468 --- /dev/null +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c @@ -0,0 +1,28 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2005-2024 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +typedef int (*callback_t) (void); + +int +caller (callback_t callback) +{ + /* Ensure some frame content to push away the return address. */ + volatile const long one = 1; + + /* Modify the return value to prevent any tail-call optimization. */ + return (*callback) () - one; +} diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c new file mode 100644 index 00000000000..3e7ac57a166 --- /dev/null +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c @@ -0,0 +1,32 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2005-2024 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +typedef int (*callback_t) (void); + +extern int caller (callback_t callback); + +int +callback (void) +{ + return 1; +} + +int +main (void) +{ + return caller (callback); +} diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp new file mode 100644 index 00000000000..7951ab41141 --- /dev/null +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp @@ -0,0 +1,90 @@ +# Copyright 2010-2024 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test that GDB can generate accurate backtraces even if some of the stack +# trace goes through a function with no debug information. + +standard_testfile -caller.c -main.c +set objmainfile ${testfile}-main.o +set objcallerfile ${testfile}-caller.o + +# recompile the inferior with or without CFI information, then run the +# inferior until the point where the important test starts +# returns TRUE on an ERROR. +proc prepare_test {has_cfi} { + global srcdir subdir srcfile srcfile2 objmainfile objcallerfile binfile + if {$has_cfi} { + set extension "cfi" + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" ${objcallerfile} \ + object [list {additional_flags=-fomit-frame-pointer \ + -funwind-tables -fasynchronous-unwind-tables}]] != "" } { + untested "couldn't compile with cfi" + return true + } + } else { + set extension "no-cfi" + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" ${objcallerfile} \ + object [list {additional_flags=-fomit-frame-pointer \ + -fno-unwind-tables \ + -fno-asynchronous-unwind-tables}]] != "" } { + untested "couldn't compile without cfi" + return true + } + } + if {[gdb_compile "${objmainfile} ${objcallerfile}" \ + "${binfile}-${extension}" binfile {}] != ""} { + untested "couldn't link object files" + return true + } + + clean_restart "$binfile-${extension}" + + with_test_prefix "${extension}" { + + if ![runto callback] then { + fail "has_cfi=$has_cfi: Can't run to callback" + return true + } + gdb_test_no_output "maint frame-unwinder disable ARCH" + return false + } +} + +if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" ${objmainfile} \ + object {debug}] != "" } { + untested "couldn't compile main file" + return +} + +if { [prepare_test false] } { + untested ${testfile}.exp +} else { + gdb_test "bt" "frame_unwind_find_by_frame failed.*" \ + "verify unwind fail without CFI" +} + +if { [prepare_test true] } { + untested ${testfile}.exp +} else { + if { [istarget "arm*-*-*"] } { + setup_kfail backtrace/31950 *-*-* + } + # #0 callback () at ... + # #1 0x00000000004004e9 in caller () + # #2 0x00000000004004cd in main () at ... + gdb_test "bt" \ + "#0 +callback \[^\r\n\]+\r\n#1 \[^\r\n\]+ in caller \[^\r\n\]+\r\n#2 \[^\r\n\]+ in main \[^\r\n\]+" \ + "verify unwinding works for CFI without DIEs" +} -- 2.46.2