From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zywIAUx33mYv0CQAWB0awg (envelope-from ) for ; Mon, 09 Sep 2024 00:19:24 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WqaE5cF+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OEaquzOv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WfN7fbEh; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6+/XQ+er; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D92611E353; Mon, 9 Sep 2024 00:19:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-11.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E92DA1E05C for ; Mon, 9 Sep 2024 00:19:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 202A7385DDF0 for ; Mon, 9 Sep 2024 04:19:22 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 238733858D39 for ; Mon, 9 Sep 2024 04:19:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 238733858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 238733858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725855543; cv=none; b=VfFx5XVVIg+tZIF+rV4nP+j4IR1HBIwWS/Vg7ljfVJL1TpZxtwjG/kAPHg7RQ1xqV1aB6QRjOBsBlh5telEzK25ZcTZKXReTPd0GBxcpxkB6Lx+PirT2CpFDEJibD5vfA1xvWFEUt/nrYfYqOGvCShJDItI/fvMK7kMqOHj+EBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725855543; c=relaxed/simple; bh=jerXtFU6xsjzWd8KwXc0j9SN0d64kGjV8rkpYh/7b8I=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=Ug6bzIIsgUVlY8pxNFP3V9BfIZU1qptIZh/e7B2B0aNhDMQ+DIl0IXn+k5Hp7D2xWDt00HMHp6b3YY0qldiLlHchia6q4iRnOOvUJJ+zMwtzjqdUm8ZPjRBdpdJxz1RGczo0G89cx1B27u349AA8YFm3jjzMdHnlfhF/IgCQXjs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D7A9721BEC for ; Mon, 9 Sep 2024 04:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725855541; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aitN8kECvVOrBcb3VXUy/1mPIVTNduTDZzQYv8KSegI=; b=WqaE5cF+NUVsQcTddo/+aq0rUDdkvWMhENJ0+eMlnGcYWZf4azUW8vMaWWz2XEiLaoAZwf 9KJBUIPz1GkonbOXjGpziElIhYXgizqEkAWI7d9dYc4IozA9RzEIiQ2x72s9zJON9n69PL S6zmHXOrxMu7phppoWFjidyMITaGvtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725855541; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aitN8kECvVOrBcb3VXUy/1mPIVTNduTDZzQYv8KSegI=; b=OEaquzOvHJ3XFYR7cYtB/q8AREcJyairfNVyNaE0br5Rr6psJK2dOHW+zbc0PqKfx7BgLX UM3uahorjsRG7zCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WfN7fbEh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="6+/XQ+er" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725855540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aitN8kECvVOrBcb3VXUy/1mPIVTNduTDZzQYv8KSegI=; b=WfN7fbEhHSuFs0BpeBYifL8KiQWsac8rgAT8hr70uTz2FHjs0lLaUYxsczICN3oSqsohR9 kpdvbLkTURiax3jmje1COUOSq+Qeqv2Go9PLkjEJSafu4vQfbF4gvGW0AIZPNplNOMdXNq fdxdgzzi8bKaHoWDcK5M68JZDJk4XhA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725855540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aitN8kECvVOrBcb3VXUy/1mPIVTNduTDZzQYv8KSegI=; b=6+/XQ+erM62kjkSFAQufoyK9bvs2Gq7ijF7yMF+MR96uebptggwLW24xAHft+JPuZl2ICx khXxIAxvAv1CZ5DQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BD0C1136A8 for ; Mon, 9 Sep 2024 04:19:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id quosLDR33mZfKgAAD6G6ig (envelope-from ) for ; Mon, 09 Sep 2024 04:19:00 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/build] Fix unused var in corelow.c Date: Mon, 9 Sep 2024 06:19:13 +0200 Message-Id: <20240909041913.929-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D7A9721BEC X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On x86_64-linux, with gcc 7.5.0 and CFLAGS/CXXFLAGS="-O0 -g -Wall" I ran into a build breaker: ... gdb/corelow.c: In member function ‘void mapped_file_info::add(const char*, const char*, const char*, std::vector&&, const bfd_build_id*)’: gdb/corelow.c:1822:27: error: unused variable ‘it’ [-Werror=unused-variable] const auto [it, inserted] ^ ... Fix this by dropping the variable it. Tested on x86_64-linux. --- gdb/corelow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index 16f07c23faa..ab2fa746de8 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -1819,8 +1819,8 @@ mapped_file_info::add (const char *soname, parsed, we group the build-id information based on the file name. As a consequence, we should see each EXPECTED_FILENAME value exactly once. This means that each insertion should always succeed. */ - const auto [it, inserted] - = m_filename_to_build_id_map.emplace (expected_filename, build_id); + const auto inserted + = m_filename_to_build_id_map.emplace (expected_filename, build_id).second; gdb_assert (inserted); /* Setup the reverse build-id to file name map. */ base-commit: 29c70787112e01cd52b53bf14bdcacb0a11e0725 -- 2.35.3