From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dlBmJts/wmb9sgsAWB0awg (envelope-from ) for ; Sun, 18 Aug 2024 14:39:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=W1cbAWji; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 883951E0D0; Sun, 18 Aug 2024 14:39:23 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 677581E08C for ; Sun, 18 Aug 2024 14:39:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 00E603850203 for ; Sun, 18 Aug 2024 18:39:21 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id E93A13861035 for ; Sun, 18 Aug 2024 18:39:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E93A13861035 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E93A13861035 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724006346; cv=none; b=ctPi/sXGki8BIctUDFGOgQbBDabx7as8hSEL7fCusXEe1syQkPhadsgZ58aQePOQMmawnvq0Mpnvs4n38aRXcJE5LbSpoGckcw4DCGLypHjV/N50FbCDYR9Z2ni8ve5p3cP23nwZ7W6c/xyW53RY2vKmnDHoSO0gKhnekIXFrvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724006346; c=relaxed/simple; bh=FT9n9mhv2M5kfN9KXsCKCP7EBanWaH8YX9UNJR7sFM4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=YeHK/YtM+aFNHUthYYhGWXOLiR26+jVwPTswqAmipYAEEFHAJ9X8LEfFzUa17vHJDyrAnfUwHwrRaI4h9/Rs0C8wD0WLzKIxkVP/kC96bcmEM8nPpCUP60CWKlXjarpFj0HUoa0cEBIdRX/rtdppxydf7Uj2VLcjpnmh5UIsAf4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724006341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wwPPte/qDDP/sADXivoasgWebSitGKYqVkFvwwlNY9c=; b=W1cbAWji/AvH/Qs81zWDl97S6oqYwpp8L4NaDQVvJe6R/YMgR2aJJg+EFIfniGHFCqqJQA ZXIPnVSp0tQ7gQEtHcpZOnUniMg71q8YhTJivpnbsyQ324qehXgMoBr5LJoo6Q0KpxF5hx Xq+R+B87N8/Du1nc1DTXkBqFMrGUnBg= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-85-UZs2q679OwyOdawR452ENQ-1; Sun, 18 Aug 2024 14:38:59 -0400 X-MC-Unique: UZs2q679OwyOdawR452ENQ-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 50B6519560B0 for ; Sun, 18 Aug 2024 18:38:58 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.8.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1E1E330001A1; Sun, 18 Aug 2024 18:38:56 +0000 (UTC) Date: Sun, 18 Aug 2024 11:38:52 -0700 From: Kevin Buettner To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Fix printing frame when reversing out of a recursive call with clang Message-ID: <20240818113852.50bf6167@f40-zbm-amd> In-Reply-To: <20240814165036.2951260-1-blarsen@redhat.com> References: <20240814165036.2951260-1-blarsen@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 14 Aug 2024 13:50:36 -0300 Guinevere Larsen wrote: > Commit bf2813aff8f2988ad3d53e819a0415abf295c91f introduced some logic to > not refresh the step frame id if it detects that the inferior is reverse > stepping out of a recursive call, so that we would still print frame > information once the inferior stops. > > However, that logic was overly specific, and wouldn't be hit for > inferiors compiled with clang because clang adds line table entries that > aren't statements, making process_event_stop_test go through a different > branch on the relevant if statement. > > Fix this by not making the code that detects "reversing out of a > recursion" an else clause to the previous if, but a standalone if block. Approved-by: Kevin Buettner