From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sy7gNbwswmYmoAsAWB0awg (envelope-from ) for ; Sun, 18 Aug 2024 13:17:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YPwJMAn2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C7EC31E0D0; Sun, 18 Aug 2024 13:17:48 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 74F111E08C for ; Sun, 18 Aug 2024 13:17:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9E06F386183B for ; Sun, 18 Aug 2024 17:17:45 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 78731385840C for ; Sun, 18 Aug 2024 17:17:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78731385840C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 78731385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724001445; cv=none; b=fxut135hjHKwXmREk9yJ168kQ5jT/7u9iaIhdKRDtEiqjKK5TbJy2Z3UE1k9r8KV0xWhvreynvCzyLbtFZv2tXOr41lNQWGAMZtQgir2M22k/Ml0Sz3KS8nVzurox1u62RZuHd2H314EbHRGuPOhB7fzSE8kdBqf0oNkP83t8MY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724001445; c=relaxed/simple; bh=LSe5TiDP/DIF9/JhCkwOIrjqEELdZ/25FIofOUqi1dY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=t5TBxdtPXs+HgRoVQ969tmFo1fhYbv6MxVY3ZiJ27W1tQ8FdxrDtZXejOd1iJFKmdbj+ap8rxiPe3S8gp8b7z3ME6KPSYFBVjFCMyOzi8e69zRRYFQ4qdL4K7UKM0LpbrTf8X/0tVWFpGOQo39zv69XYzIuGs6OlOIOCaIT2WF8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724001443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mvGHiaQkyedyAJFuevNG+lyztdC+QGYoVTPYArNS9RU=; b=YPwJMAn29ZHTBftXeUYHl1vmoHitE2l7UQqiXdJOmzqGUWz7vXsI/PVsi6kAV6VXa/A8xl ScIZDRJ28fGPbW6RRfbekVcbRJqRPe3FCXb29/L09+aSGzl+ZN+5v6feDTnNISP8quJv/Q EaBvbx6wimASx8IW1mZyjIEliaD/9uo= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-hgV4GtZVNvufCdzX30HWCw-1; Sun, 18 Aug 2024 13:17:17 -0400 X-MC-Unique: hgV4GtZVNvufCdzX30HWCw-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8CF971955F43; Sun, 18 Aug 2024 17:17:16 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.8.12]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0EE8F195605A; Sun, 18 Aug 2024 17:17:14 +0000 (UTC) Date: Sun, 18 Aug 2024 10:17:09 -0700 From: Kevin Buettner To: Andreas Schwab Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Fix m68k OS ABI sniffer Message-ID: <20240818101709.27e020dc@f40-zbm-amd> In-Reply-To: <871q2r6o9v.fsf@igel.home> References: <871q2r6o9v.fsf@igel.home> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 14 Aug 2024 18:51:40 +0200 Andreas Schwab wrote: > Do not override the generic OS ABI sniffer. > > Fixes: 3eba3a011a8 ("Various m68k fixes for gdb") > --- > gdb/m68k-tdep.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/gdb/m68k-tdep.c b/gdb/m68k-tdep.c > index 439ebd241e8..0d268aa947b 100644 > --- a/gdb/m68k-tdep.c > +++ b/gdb/m68k-tdep.c > @@ -1353,11 +1353,19 @@ static enum gdb_osabi > m68k_osabi_sniffer (bfd *abfd) > { > unsigned int elfosabi = elf_elfheader (abfd)->e_ident[EI_OSABI]; > + enum gdb_osabi osabi = GDB_OSABI_UNKNOWN; > > if (elfosabi == ELFOSABI_NONE) > - return GDB_OSABI_SVR4; > + { > + /* Check note sections. */ > + for (asection *sect : gdb_bfd_sections (abfd)) > + generic_elf_osabi_sniff_abi_tag_sections (abfd, sect, &osabi); > + > + if (osabi == GDB_OSABI_UNKNOWN) > + osabi = GDB_OSABI_SVR4; > + } > > - return GDB_OSABI_UNKNOWN; > + return osabi; > } LGTM. Reviewed-by: Kevin Buettner