From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8UkrCJQgsGaGXTwAWB0awg (envelope-from ) for ; Sun, 04 Aug 2024 20:45:08 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XyG9r8gW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 09F591E0D0; Sun, 4 Aug 2024 20:45:08 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B7E0E1E0AC for ; Sun, 4 Aug 2024 20:45:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D8F423858289 for ; Mon, 5 Aug 2024 00:45:04 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 72D7D385841C for ; Mon, 5 Aug 2024 00:44:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72D7D385841C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 72D7D385841C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722818681; cv=none; b=nSCOEh1TD0Hp/fqHnZ5JqFpGOoiEFF8KAuaUKc3NLSjiF3DCvjM5IuQ5Hk8mw56HASNAgfxQPZGP3RTuO2uVgzOzOHEp4Y87YaL782HzcRdoixLPdOoHqfmr+83/hBmvEyRdY49CzM4ceHr/+cA8VVSj58C/slu65EYSkmZztWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722818681; c=relaxed/simple; bh=3RjkxCTHpuERuz25Mz2PFBqwQw5XnfS67c+Cfor9KCk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=GzUmoPayRhTcmtDr8h3P562QCdDTZR9aUegpncF6jDEXuXw4sQpNtWDRf1VXBJGHw8qDvqBo12vx1UZ09puzF5L9dDJXW0jLN/OryV7gVZ1S6ArK12qz74VWCC+/JD0jQktDJkw6QrHujaVhDcUw5yf4kKdMmyLYWmd7SVXuXlo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722818679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vzZt5y8fCF851tT0eZXawdG6lamDr56qHEHczSTRz+Q=; b=XyG9r8gWoy7nlKQkLCLKOK/6U61CoK5sHVztL0aeV0HQL/83rN/FRCrWBrrwyWtpxzyQfO naaDqa8GGhf41VXV2v6vwDBKNfkLARFG9nWk7VYblTxl7DzMPRMR3HQRV+FlQp0iC/xMi+ QyVYgFsBnOMp7DLEhiuk8c7t3t6VKbU= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-2WuxIZ2jMWCPw7tf4NVtcA-1; Sun, 04 Aug 2024 20:44:36 -0400 X-MC-Unique: 2WuxIZ2jMWCPw7tf4NVtcA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 126731955F43; Mon, 5 Aug 2024 00:44:35 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.34.71]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0D2D319560AE; Mon, 5 Aug 2024 00:44:33 +0000 (UTC) Date: Sun, 4 Aug 2024 17:44:27 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb] Notice when stepping into different file Message-ID: <20240804174427.01d03a26@f40-zbm-amd> In-Reply-To: <20240802055730.11865-1-tdevries@suse.de> References: <20240802055730.11865-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 2 Aug 2024 07:57:30 +0200 Tom de Vries wrote: > Instead, change the behaviour of "print frame-info" == auto to also use > source-and-location when stepping into another file, which gets us: > ... > (gdb) n > foo () at test.h:1 > 1 return 1; > ... LGTM. (Aside from git eating the #include line in the commit remarks.) Reviewed-by: Kevin Buettner