From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gChbKXKPomYitjEAWB0awg (envelope-from ) for ; Thu, 25 Jul 2024 13:46:26 -0400 Received: by simark.ca (Postfix, from userid 112) id A23F01E0D0; Thu, 25 Jul 2024 13:46:26 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 90B571E097 for ; Thu, 25 Jul 2024 13:46:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 07F633858410 for ; Thu, 25 Jul 2024 17:46:24 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2EFD93858414 for ; Thu, 25 Jul 2024 17:45:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2EFD93858414 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2EFD93858414 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721929520; cv=none; b=rKVg+H7rJYvoIFUtnhPUjBwrDzsSfnJMrB7EGVBKWLx48VRcbDB2HQo0ue4QwQV3LKxb7/zsPoEGCjfezzYbCAFef+S7hAr+BknZNvzn3B2qs8sopxHrUruEzer0qajEbk2Fviz7OD8scbB6dazNnu4+N0MuFMdXleU+azLppgI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721929520; c=relaxed/simple; bh=Zd8Am8Wdoc4dzMerD9+xS3Bqg23s5Bj64ToTTgzUq+w=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=rmDE+Dx1pIiIKkuCC5eagCqKoDHk5geTo93GMsZSnC5vsM5sL5+ONLLLKKBu3YVEvv/VWYk4nUp5Ol+BMm5O84bbSNVfMJpaMLGq6yQcMx1Fe+gklnrtvMMM7HuFKTwNCRGKr9mCnWUwF2cjvVmqLmQPF6C8Ud1K1uxduq+Knis= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost.localdomain (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9DBCC1E0D1; Thu, 25 Jul 2024 13:45:16 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 3/3] gdb: remove find_and_open_solib so_list method Date: Thu, 25 Jul 2024 13:41:37 -0400 Message-ID: <20240725174514.129360-4-simon.marchi@efficios.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240725174514.129360-1-simon.marchi@efficios.com> References: <20240725174514.129360-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1173.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi Now that the nto port is removed, this is unused. Change-Id: I86565310cdbcde17a837eb10585cdd153f4f03d8 --- gdb/solib-svr4.c | 1 - gdb/solib.c | 7 ------- gdb/solist.h | 8 -------- 3 files changed, 16 deletions(-) diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c index 9f377f427c87..8c3ff39d2ac0 100644 --- a/gdb/solib-svr4.c +++ b/gdb/solib-svr4.c @@ -3364,7 +3364,6 @@ const struct solib_ops svr4_so_ops = open_symbol_file_object, svr4_in_dynsym_resolve_code, solib_bfd_open, - nullptr, svr4_same, svr4_keep_data_in_core, svr4_update_solib_event_breakpoints, diff --git a/gdb/solib.c b/gdb/solib.c index 931fa571be25..49f607514dc7 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -114,7 +114,6 @@ show_solib_search_path (struct ui_file *file, int from_tty, static gdb::unique_xmalloc_ptr solib_find_1 (const char *in_pathname, int *fd, bool is_solib) { - const solib_ops *ops = gdbarch_so_ops (current_inferior ()->arch ()); int found_file = -1; gdb::unique_xmalloc_ptr temp_pathname; const char *fskind = effective_target_file_system_kind (); @@ -297,12 +296,6 @@ solib_find_1 (const char *in_pathname, int *fd, bool is_solib) target_lbasename (fskind, in_pathname), O_RDONLY | O_BINARY, &temp_pathname); - /* If not found, and we're looking for a solib, try to use target - supplied solib search method. */ - if (is_solib && found_file < 0 && ops->find_and_open_solib) - found_file = ops->find_and_open_solib (in_pathname, O_RDONLY | O_BINARY, - &temp_pathname); - /* If not found, next search the inferior's $PATH environment variable. */ if (found_file < 0 && sysroot == NULL) found_file = openp (current_inferior ()->environment.get ("PATH"), diff --git a/gdb/solist.h b/gdb/solist.h index f0d22080de17..6b2a97adf7a7 100644 --- a/gdb/solist.h +++ b/gdb/solist.h @@ -132,14 +132,6 @@ struct solib_ops /* Find and open shared library binary file. */ gdb_bfd_ref_ptr (*bfd_open) (const char *pathname); - /* Optional extra hook for finding and opening a solib. - If TEMP_PATHNAME is non-NULL: If the file is successfully opened a - pointer to a malloc'd and realpath'd copy of SONAME is stored there, - otherwise NULL is stored there. */ - int (*find_and_open_solib) (const char *soname, - unsigned o_flags, - gdb::unique_xmalloc_ptr *temp_pathname); - /* Given two so_list objects, one from the GDB thread list and another from the list returned by current_sos, return 1 if they represent the same library. -- 2.45.2