From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id I3rUIxHfl2aTuykAWB0awg (envelope-from ) for ; Wed, 17 Jul 2024 11:11:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oriz3UuO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=uzcOqZ8k; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oriz3UuO; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=uzcOqZ8k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7EC0A1E0C3; Wed, 17 Jul 2024 11:11:13 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 56DB51E097 for ; Wed, 17 Jul 2024 11:11:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B0552385E45D for ; Wed, 17 Jul 2024 15:11:10 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 1BC8C385841D for ; Wed, 17 Jul 2024 15:10:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BC8C385841D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1BC8C385841D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721229050; cv=none; b=UeYynfKT20SwLnT5aAkW17zPCX1a3c7t/ctvVIWwIu9OhlKPLoSLVR3VBZ82KXS7Y41JmBKOjLYhzmwedDnseeRkuXXmkuOmhU19h6bKKXiRaAB4GIelQNVTXtp3I1QilRJjbcMKUrsglOQwFHd+76/CQMBdkqk4vNhLTBHMb30= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721229050; c=relaxed/simple; bh=34/hr3rogE/AORgVwjDQvXouMylF3Wgdi5ylAn4Ndn0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=NMp4UIsn/3GqgWxRGG3DiOeBj/8iPTezGiXH9G0AWTpAZqtyxV6J5HSkyQfSrkunCNE8GcsW8zVuxYkefj61TnnumHjWwQvXMMla721gLERK/bg458mIXvuyoSWNoIKs6wuQzRJnS3LJWP+UB3Ev2wYSWuqpLWvMM5OVKF5gxSQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 35C031FB8B; Wed, 17 Jul 2024 15:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1721229048; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=EDfVUWOKlLSpHGOBPCRfpnpCCwOH3IIlSJlNuhCjCWk=; b=oriz3UuOU3wJFRaYs0t2v1cnEnFG7c1lYUDEbrmpKEVVA4k40SGxOv0syNEsfFkKmq1JGU OJpch3GH0g4gM7v8NCcTCKLtSQEF0KIx2efscoH3yBXWR9Gv7KOsGUimtY5tLqhdJH+WUX N67wBebYhMkU0rN5S8/BRQuipyFBmvY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1721229048; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=EDfVUWOKlLSpHGOBPCRfpnpCCwOH3IIlSJlNuhCjCWk=; b=uzcOqZ8kRfQ70lRrq1OQ5k18Cc2SVkglq0l6pjIMB9K74Mjwwd243rPvSGvPsHiC/7WD3M x6RsBwuQ/P7PMrDQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1721229048; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=EDfVUWOKlLSpHGOBPCRfpnpCCwOH3IIlSJlNuhCjCWk=; b=oriz3UuOU3wJFRaYs0t2v1cnEnFG7c1lYUDEbrmpKEVVA4k40SGxOv0syNEsfFkKmq1JGU OJpch3GH0g4gM7v8NCcTCKLtSQEF0KIx2efscoH3yBXWR9Gv7KOsGUimtY5tLqhdJH+WUX N67wBebYhMkU0rN5S8/BRQuipyFBmvY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1721229048; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=EDfVUWOKlLSpHGOBPCRfpnpCCwOH3IIlSJlNuhCjCWk=; b=uzcOqZ8kRfQ70lRrq1OQ5k18Cc2SVkglq0l6pjIMB9K74Mjwwd243rPvSGvPsHiC/7WD3M x6RsBwuQ/P7PMrDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 18933136E5; Wed, 17 Jul 2024 15:10:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 66aDBPjel2bQFQAAD6G6ig (envelope-from ); Wed, 17 Jul 2024 15:10:48 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Luis Machado Subject: [RFC] [gdb/testsuite] Add xfail in gdb.base/hbreak.exp Date: Wed, 17 Jul 2024 17:10:55 +0200 Message-Id: <20240717151055.21480-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.20 X-Spamd-Result: default: False [1.20 / 50.00]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On an aarch64-linux system with 32-bit userland running in a chroot, and using target board unix/mthumb I get: ... (gdb) hbreak hbreak.c:27^M Hardware assisted breakpoint 2 at 0x4004e2: file hbreak.c, line 27.^M (gdb) PASS: gdb.base/hbreak.exp: hbreak continue^M Continuing.^M Unexpected error setting breakpoint: Invalid argument.^M (gdb) FAIL: gdb.base/hbreak.exp: continue to break-at-exit after hbreak ... due to this call in arm_linux_nat_target::low_prepare_to_resume: ... if (ptrace (PTRACE_SETHBPREGS, pid, (PTRACE_TYPE_ARG3) ((i << 1) + 1), &bpts[i].address) < 0) perror_with_name (_("Unexpected error setting breakpoint")); ... This problem does not happen if instead we use a 4-byte aligned address. I'm not sure if this is simply unsupported or if there's a kernel bug of some sort, but I don't see what gdb can do about this. Tentatively mark this as xfail. Tested on aarch64-linux. --- gdb/testsuite/gdb.base/hbreak.exp | 40 ++++++++++++++++++++++++++----- 1 file changed, 34 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.base/hbreak.exp b/gdb/testsuite/gdb.base/hbreak.exp index 73a3e2afb67..b140257a23e 100644 --- a/gdb/testsuite/gdb.base/hbreak.exp +++ b/gdb/testsuite/gdb.base/hbreak.exp @@ -27,10 +27,38 @@ if ![runto_main] { set breakline [gdb_get_line_number "break-at-exit"] -gdb_test "hbreak ${srcfile}:${breakline}" \ - "Hardware assisted breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*${srcfile}, line ${breakline}\\." \ - "hbreak" +set re_loc "file \[^\r\n\]*$srcfile, line $breakline" +set re_dot [string_to_regexp .] -gdb_test "continue" \ - "Continuing\\.\[ \r\n\]+Breakpoint \[0-9\]+, .*break-at-exit.*" \ - "continue to break-at-exit after hbreak" +set addr 0x0 +gdb_test_multiple "hbreak ${srcfile}:${breakline}" "hbreak" { + -re -wrap "Hardware assisted breakpoint $decimal at ($hex): $re_loc$re_dot" { + set addr $expect_out(1,string) + pass $gdb_test_name + } +} + +set have_xfail 0 +if { [istarget arm*-*-*] } { + # When running 32-bit userland on aarch64 kernel, thumb instructions that + # are not 4-byte aligned may not be supported for setting a hardware + # breakpoint on. + set have_xfail [expr ($addr & 0x2) == 2] +} + +set re_xfail \ + [string_to_regexp \ + "Unexpected error setting breakpoint: Invalid argument."] + +gdb_test_multiple "continue" "continue to break-at-exit after hbreak" { + -re -wrap "Continuing\\.\[ \r\n\]+Breakpoint \[0-9\]+, .*break-at-exit.*" { + pass $gdb_test_name + } + -re -wrap $re_xfail { + if { $have_xfail } { + xfail $gdb_test_name + } else { + fail $gdb_test_name + } + } +} base-commit: 0ed152c5c6b3c72fc505b331ed77e08b438d643a -- 2.35.3