From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gwmhDBbllma90igAWB0awg (envelope-from ) for ; Tue, 16 Jul 2024 17:24:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=yGL8waK/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1ECE21E0C3; Tue, 16 Jul 2024 17:24:38 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C0C011E030 for ; Tue, 16 Jul 2024 17:24:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DFC4B38708C0 for ; Tue, 16 Jul 2024 21:24:34 +0000 (GMT) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2059.outbound.protection.outlook.com [40.107.223.59]) by sourceware.org (Postfix) with ESMTPS id BA05D3858C56 for ; Tue, 16 Jul 2024 21:24:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA05D3858C56 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA05D3858C56 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.223.59 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1721165058; cv=pass; b=W9J3bcewm41qQMFg8k36E2c2YaheXziv0Vy5B75oVEsq3e7jK1S9/4a4lwUQvW35blWlxVw3OgH906zt0KAfUgN7nEtS57fG4XFHXUavz4uJfCE5RFqHtk6Jf1YQpOPTSavMkOM/Z4B7M4TPdIuCDFZrrS4/X8SuQXAJiAa7tbo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1721165058; c=relaxed/simple; bh=gD7nntWWSbw5uYO55SCurSbPk62+1QZEjXmQkRmhB6k=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=MNkFIsMGYNWr4M26LlXaUPm2pzDAQEtXG12TE0ZD1FOsgRSoMTKMiou4z21l5/gGaJ51tiSdHR/Sk4cUtwjyzGViAhjG8z2VaWaKpOg+01N+BCVezAHNby8+ZgfIy1wJ42TOFaH1aa3ZkJWMOssR6yMAkIObMaGVeBDc/1BGsk4= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nW2Nt93FYO1l3El84Yq4NbGRjsXMKWDeYBbZbKw3DAcL9V3o7pv6A7FIxz7Wtede/Nt8sBHzPmjA7XwOjHBmz8hAMVGzYjz2TtsY0FyiTIkBYjZ2//Tq2vYKE7yjtpjw8FXvp+19ZZq9x1zAn8l/SefmqrX/K+f/900rN0AWRw4vyZ2tqEmF3CRhdkkJNZ6PKfNhUrvMohhC9gIjOr/FucX3VRjM3Kb2TL6hA0hTlK0GOVSQaDCvslPvn42s5R9/UwKpdy574cI91Es3uO7MR+faHnphSluoQvOfHdITGaucBQW18ifMS6TaDQcMo6UyjbHCT47u/6Xi7OBerKfreA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8fMwGqG1QegPJIroCXNRuLO0TkQ45uUtabCJbqhiHVc=; b=eizu8VzWs0YHYXA0Vdf6Q0px5nNT9cRgIu6/vDHt2/EZEk7UusLReriGg1EHtda6B5dErrAFJiP3CQvt99hLjwurVupK3yr8kETipTC8ZUIjm5l/FHvkVpTe0lZqM0UCZvUKpABWwS1ORVwuriFASS9A7W1/X/8g2NsVhY6K+EngHhkCYI10meBDZlrHVkz6FI3H2mfZ8wFgohjWRIg+hAQMZh4EAzBfHtp4Vjp+oljRb9DdmVYUpLfBK9vNdPzMA+zSsQ3AZ+yN5oAYJTj05tgWSeSI+mQ+Mt2k8shJ9FjNIYzeclFtBhosRqcC/r/KuSb6LJVFlKnCu+8TbrrFLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=polymtl.ca smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8fMwGqG1QegPJIroCXNRuLO0TkQ45uUtabCJbqhiHVc=; b=yGL8waK/rNTxvTHtH5WDRNAXMIsSBQev5tHkCTOyuZ70lcR9I2gGbSmFbjshXpGfdTenR0aPXtPR9JdX+JeTkhIIDqRJcZJWorgUITHXlf3O6eXYLknwmbxwteGdoYMOmZnX4RQwroXA1hIRnPvb+gctYCrhx0TevKp+ZiDZNIk= Received: from SN4PR0501CA0032.namprd05.prod.outlook.com (2603:10b6:803:40::45) by DM6PR12MB4355.namprd12.prod.outlook.com (2603:10b6:5:2a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Tue, 16 Jul 2024 21:24:13 +0000 Received: from SN1PEPF000397B4.namprd05.prod.outlook.com (2603:10b6:803:40:cafe::52) by SN4PR0501CA0032.outlook.office365.com (2603:10b6:803:40::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.13 via Frontend Transport; Tue, 16 Jul 2024 21:24:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF000397B4.mail.protection.outlook.com (10.167.248.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7784.11 via Frontend Transport; Tue, 16 Jul 2024 21:24:13 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 16 Jul 2024 16:24:11 -0500 Date: Tue, 16 Jul 2024 22:24:03 +0100 From: Lancelot SIX To: Simon Marchi CC: Subject: Re: [PATCH] gdb, gdbserver, gdbsupport: use [noreturn] instead of ATTRIBUTE_NORETURN Message-ID: <20240716212403.3uzr723mw7rbv7lw@khazad-dum> References: <20240716200218.2249262-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240716200218.2249262-1-simon.marchi@polymtl.ca> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397B4:EE_|DM6PR12MB4355:EE_ X-MS-Office365-Filtering-Correlation-Id: 6739e3b1-48f0-4b51-b2fe-08dca5dda3c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ARA1KAXQnSYOJ6PDIRQrY2ux75+S3YDiOTbRGkaJ4lhgdTeUubbKJFphZbpE?= =?us-ascii?Q?HpoEt/N68a0zYcySHbTeI+LDobIS8DAblADpNPbBUUZYZsx/W/HJH2fMezqN?= =?us-ascii?Q?vLfeObcVD86IPok/nVbERQHgEUdkC2ChEt08oVVHWUoRBY2lQ5pY6W2rLkaJ?= =?us-ascii?Q?yhA9Kkud53MVn6Em0ytmHsh6wdsw0HLFLh/xsMEK17hAV3VUc7A40Bh8PZx4?= =?us-ascii?Q?s1DwByZ7UwgIslzA/hl89CH7DUEePc1kNH3SiQ6oBqj7/rrqJ5DwhBj0ab+3?= =?us-ascii?Q?8uHMaMvDo5KXEY6JncRyUuy6FCDjXe0jKinNPenLVt42u/uUZ8z1+4PR4i1N?= =?us-ascii?Q?Iq174hpXSLokJt8HjiN+AsKhA+ZjXD6llFEamJLWVe+g8eLD23rgzYUXwKNG?= =?us-ascii?Q?S+yL87E1HB5TGkAdNhEk3Yhlh+5QhMwizKyAKnHABwomTF+lUmriTBV6Fn+b?= =?us-ascii?Q?STGCI4UUkkYnuz5Cm9sUnRDaZlAIuYoS3qte406sFNbe2qK4I1DTfFRrJ9GY?= =?us-ascii?Q?hpsi8SNUQdi03CROhGm4MQqsKDsifYjSVXYXwsvIPXPpv91h2MmMTwGxu9A0?= =?us-ascii?Q?VEJ0Ovf0L48+GvRZLWf47y02ApKQ8834VzG7HOlO0eLOq2CgCKSdeSuLcBBc?= =?us-ascii?Q?bx7L6p6jdvqeGf3EQJa9EqKjsb9Ih1V3ULsbbg0yXyKchYdHQaC//LStUAjU?= =?us-ascii?Q?OtEoXHhQ0OdVxJKdSYhrzYuQ1Mt3x621+Af8N/9FSMCdooAuAIuUZ8jbgXdM?= =?us-ascii?Q?1S1YMOLFrDxE/QaFCjXWF4aWcu+8OxsnwdOOJ1lUCmvD4V08RdgxbdwB3znU?= =?us-ascii?Q?tPXM5hkNgo+F1JvZrpIn0NwSLkE5RTlQlPgiOAYgzdJ5EsY0p9UhrCGqRVkX?= =?us-ascii?Q?M0WCpViJn6vkmu6I6z3I1W06yjJh0LrB2EEhklusCW+Nk2LGovxcNB2bOp+E?= =?us-ascii?Q?JnUCo5X/y+Bv4leW5eof7xxTsQmCpgOLjBYhKUZv4asq0pU5ZycQeZ3YUrAj?= =?us-ascii?Q?ISfff5XucCQ19t2nbuJqfC9Rf7QXNkm4suk/A1gVFaP9Ye/NTd8rMXLjCypW?= =?us-ascii?Q?4Y0NnpqE2CO+LkXOhUJQBOVxkeOdM6jXS2/Jr+gGa59KP7s/hxObLBCeWhJw?= =?us-ascii?Q?S1g61+IVVi25+Wj2p3bGZX5U76oqJVagBC/JipkT9/YyEcKHTDLFxmc0AEHV?= =?us-ascii?Q?uD9SxTo9VsRUdbMY9wG3JMnyiaqv1qSgiLNeoiM2s8SGirVCeIF6tz58Oy3y?= =?us-ascii?Q?BUV2qRQLbQI2uwk6Zt1Nw8YccUeeUk6iC7OftborgXQl822LpCIAa6ojWwgA?= =?us-ascii?Q?3Hqj/eytL1V5BbD83/r3KIXDOaBxQvWcecV3SAVMz2PG9/onbntfydEUMiGK?= =?us-ascii?Q?41JDtyLf8I+XtmA+STnH/xgxq28uNoKuMl5E3YI+7jRB6tA01WMuSOY8bDzF?= =?us-ascii?Q?cCrKzT/YzrDIKMcPWXGBcyl723NYN/XW?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2024 21:24:13.1719 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6739e3b1-48f0-4b51-b2fe-08dca5dda3c0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397B4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4355 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, Jul 16, 2024 at 04:02:12PM -0400, Simon Marchi wrote: > C++ 11 has a built-in attribute for this, no need to use a compat macro. > > Change-Id: I90e4220d26e8f3949d91761f8a13cd9c37da3875 Hi Simon, Thanks for doing this! FWIW, this looks good to me. Reviewed-by: Lancelot Six Best, Lancelot.