Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Lancelot SIX <lancelot.six@amd.com>
To: Tom Tromey <tom@tromey.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Use bool in thread_events
Date: Tue, 28 May 2024 20:59:32 +0100	[thread overview]
Message-ID: <20240528195843.bpmnbm4jcvbqartl@khazad-dum> (raw)
In-Reply-To: <20240527214716.98382-1-tom@tromey.com>

On Mon, May 27, 2024 at 03:47:16PM -0600, Tom Tromey wrote:
> This changes target_ops::thread_events and target_thread_events to use
> 'bool'.  The callers were already doing this.
> 
> Tested by rebuilding.

Hi,

Just FYI, I did also rebuild with the amdgpu support (to catch
amd-dbgapi-target.c), and all looks good to me.

Reviewed-by: Lancelot Six <lancelot.six@amd.com>

Best,
Lancelot.


      parent reply	other threads:[~2024-05-28 20:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 21:47 Tom Tromey
2024-05-28 13:56 ` Simon Marchi
2024-05-28 19:59 ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528195843.bpmnbm4jcvbqartl@khazad-dum \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox