From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OLZLL87yOGbJUAgAWB0awg (envelope-from ) for ; Mon, 06 May 2024 11:10:06 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=jetbrains.com header.i=@jetbrains.com header.a=rsa-sha256 header.s=googleapps header.b=d4Z69emm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BE1BA1E0C1; Mon, 6 May 2024 11:10:06 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ABD841E092 for ; Mon, 6 May 2024 11:10:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 597F4385841E for ; Mon, 6 May 2024 15:10:04 +0000 (GMT) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 439E63858CD1 for ; Mon, 6 May 2024 15:09:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 439E63858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=jetbrains.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jetbrains.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 439E63858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715008181; cv=none; b=mELk6L3vXJAimxyglUz1nr+khKCqlb6HfyswMpM2bXcB4xjurIAHnF/0ocscIhNdOxSLvmgHbvFTjdXYdmzMfl5Rh71t2pr5f1ZpaOsAgMlIYy/Bofjo7tyl064s06ipBFpq4yhR3lCvS0qZI0qeA2kBDZM9Ku1cRyTgMjbg7YE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715008181; c=relaxed/simple; bh=1dhgw6bBu6/CbAew9Dl5xcZ2T5hcxXefT+4EG7KCouY=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=YaQaKsh83szJhaiw8rYUdrG+P7LsuXkOoWBzT0Krw7rBW7xaDWuX6PdM1EV+TlTDFZGEF6A5DVTNuwq2EWKSg4Z1/7TFc3wgYQwiYh24Jx7dmHWsK8oYG/mR5czMhAYHgU74raOKXAe/WN7aY6xMT3zYD8G2YluA+sy3O9lOqTw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2e2a4c20870so26074291fa.3 for ; Mon, 06 May 2024 08:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetbrains.com; s=googleapps; t=1715008176; x=1715612976; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RuJ3l54/4/F9ZQHaEfq053/afFv3Glh6YIoAS9DCc8o=; b=d4Z69emm+zNPKHs9kLbu614V91X/GKSenl954L0ZjxTVl5lZnkilFGQHTWkurZsxvx xMtOK+HoeHmTgECW7b0VnBYu2IYkW2OXP8SBzl14GEISgqDg1EFty+BVzGzLbuMih6vS OhXD7btvAWPKfXjZ2YY/RLiibWSj6eR9DGPm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715008176; x=1715612976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RuJ3l54/4/F9ZQHaEfq053/afFv3Glh6YIoAS9DCc8o=; b=liedFkPZqfhYCM9BoYkXCdicwwdK0LXQxX/eZ0rXBgMxkfB01al9AwBmMw3fqeNmto Rlu1K9IK/oxJZsA3NZX9aWory7NaZqqrb1Kbl6Yqrum0ZMoTQLM5PmtGu5TXGz9Mls8Y 7DpNjW2aSWSZMm3HFJ6xuuO3UZu95dFh90TPiP8N+soJKEzPvo38B/BADXKldgQ5TLwz PpAdE+agsvJHGuYFM7KO9L0mOP/FULBQDcSvKCK1R9TmmEKb0U42fIpMq5PiMcyT67+j 9pp6F6zw/akJHJzayU27I+GEC9iLYOKA5Kxk6Fmly0mkxWVDEBjqkLTXHbgsBYH1XGqF DL6w== X-Gm-Message-State: AOJu0Yxhkz5nxyP7BWY2MHJQIP6WMcguvAWPmHj2TC/8zfWV/usevKej 0xOtJ/OmTXO7TW15X60OrqrbmJlic4+xXOIcMKkEt6yN7YnmzqaQ9+tCFwfDgA2llDSb6AFxeNs = X-Google-Smtp-Source: AGHT+IGVW4JWtcyVaF6ZXjryzPODRYw32Nr4DlA62KRBzGSh0QxSIX0XDRspRymTRPxdFnXh19Tvbw== X-Received: by 2002:a2e:602:0:b0:2e3:cba4:229 with SMTP id 2-20020a2e0602000000b002e3cba40229mr305996ljg.4.1715008176255; Mon, 06 May 2024 08:09:36 -0700 (PDT) Received: from lubuntu2.labs.intellij.net (ad96e1c12.dsl.de.colt.net. [217.110.28.18]) by smtp.gmail.com with ESMTPSA id e30-20020a5d595e000000b0034e8784473dsm7965982wri.41.2024.05.06.08.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 08:09:35 -0700 (PDT) From: Dmitry Neverov To: gdb-patches@sourceware.org Cc: dmitry.neverov@jetbrains.com Subject: [PATCH v3][PR symtab/30520 3/4] gdb/symtab: compute match_type outside the loop Date: Mon, 6 May 2024 17:09:19 +0200 Message-Id: <20240506150920.1220092-3-dmitry.neverov@jetbrains.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240506150920.1220092-1-dmitry.neverov@jetbrains.com> References: <20240506150920.1220092-1-dmitry.neverov@jetbrains.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org It will be used for all segments in a qualified name, not only the last one. --- gdb/dwarf2/read.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index a49ade9dc31..f2842f0f581 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -16637,6 +16637,9 @@ cooked_index_functions::expand_symtabs_matching language_ada }; + symbol_name_match_type match_type + = lookup_name_without_params.match_type (); + for (enum language lang : unique_styles) { std::vector name_vec @@ -16693,8 +16696,6 @@ cooked_index_functions::expand_symtabs_matching "x::a::b". */ if (symbol_matcher == nullptr) { - symbol_name_match_type match_type - = lookup_name_without_params.match_type (); if ((match_type == symbol_name_match_type::FULL || (lang != language_ada && match_type == symbol_name_match_type::EXPRESSION))) -- 2.34.1