From: Kevin Buettner <kevinb@redhat.com>
To: Aditya Vidyadhar Kamath <akamath996@gmail.com>
Cc: gdb-patches@sourceware.org, tom@tromey.com,
ulrich.weigand@de.ibm.com,
Aditya Vidyadhar Kamath <Aditya.Kamath1@ibm.com>
Subject: Re: [PATCH] Add gdb.threads/thread_events.exp to run in AIX as well
Date: Wed, 1 May 2024 18:57:42 -0700 [thread overview]
Message-ID: <20240501185742.03b7fee2@f39-zbm-amd> (raw)
In-Reply-To: <20240429014855.3031-1-akamath996@gmail.com>
On Mon, 29 Apr 2024 07:18:57 +0530
Aditya Vidyadhar Kamath <akamath996@gmail.com> wrote:
> From: Aditya Vidyadhar Kamath <Aditya.Kamath1@ibm.com>
>
> ---
> gdb/testsuite/gdb.threads/thread_events.exp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.threads/thread_events.exp b/gdb/testsuite/gdb.threads/thread_events.exp
> index 100205e5f58..11a89139384 100644
> --- a/gdb/testsuite/gdb.threads/thread_events.exp
> +++ b/gdb/testsuite/gdb.threads/thread_events.exp
> @@ -23,7 +23,8 @@
>
> # This test has only been verified with Linux targets, and would need
> # to be generalized to support other targets
> -if {![istarget *-*-linux*]} {
> +
> +if {!([istarget *-*-linux*] || [istarget *-*-aix*])} {
> return
> }
>
Could you update the comment to indicate that it's been verified to
work with (both) Linux and AIX targets?
Once that's done, you have my approval:
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2024-05-02 1:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 1:48 Aditya Vidyadhar Kamath
2024-05-02 1:57 ` Kevin Buettner [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-23 16:56 Aditya Kamath1
2024-04-25 13:51 ` Tom Tromey
2024-04-29 2:00 ` Aditya Kamath1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501185742.03b7fee2@f39-zbm-amd \
--to=kevinb@redhat.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=akamath996@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=ulrich.weigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox