From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uFvUCTsVK2asSjwAWB0awg (envelope-from ) for ; Thu, 25 Apr 2024 22:45:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JDwwOadi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 150081E0C0; Thu, 25 Apr 2024 22:45:15 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C7D231E030 for ; Thu, 25 Apr 2024 22:45:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FFB73858417 for ; Fri, 26 Apr 2024 02:45:12 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8A2933858C50 for ; Fri, 26 Apr 2024 02:44:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A2933858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8A2933858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714099494; cv=none; b=x/+gJFUX7kp5sQB6k//bY7+Cd/cgEA+HHQ2Jdr9ViNRKN7O5zpipBBM4txXmPQS2hoqy7SAvmsnO4H1CUWOdQSS9JXBR5UDWSXxVfl+nq+2cKfVW+A8qeuR7mQ0GewtcoqAQwIighoRZhqTednwmer+ZaSD6wRUS5o9FWN61P7k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714099494; c=relaxed/simple; bh=1NT7Uxpx9bnSs9xFN7dX89WEWy99UrBokRVQYy6hvoY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Y194DtGsQhPDyb7h5+VRtW1lTprp0A+EU2R9mrkbyz7hg0Rdmjz4LtVW4Y8t1UzO8yLgBjUhzgzWiOuwm66jzGwznEXHB4SXh3CGJzEHdF7KytysQkI2YjKCTj+wduLqL4iYAdCnEOYxBQ1f4Jtu11vTMsvC652o5K285DLf1J8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714099493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H/zF0jSlLS6ggPVg0JBp9vL2tFjpcKAYoFNxS3ZveKc=; b=JDwwOadi8zlcN29ZC0Uxt278W+2lnvHwT117EZLdcce9mZdpKWXIkNV/3QWvY3+LnCtxGr fKrOkiEwfEXWGJ+h2gQbVScA79SKSGafWfXT7Jk9rVYnRyVIu/DcmStzJAvPCCIbvtCQMP iLwi0ougHZjtRkVrmIeAse1QPKfZiok= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-330-EW4sdsGmP6yJ-v-_73IxYg-1; Thu, 25 Apr 2024 22:44:51 -0400 X-MC-Unique: EW4sdsGmP6yJ-v-_73IxYg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0BCBE3820EAB; Fri, 26 Apr 2024 02:44:51 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.16.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F80F6958; Fri, 26 Apr 2024 02:44:50 +0000 (UTC) Date: Thu, 25 Apr 2024 19:44:49 -0700 From: Kevin Buettner To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org, Luis Machado Subject: Re: [PATCH v4] gdb/testsuite: Add gdb.base/memops-watchpoint.exp Message-ID: <20240425194449.79797d27@f39-zbm-amd> In-Reply-To: <20240426014626.1668298-1-thiago.bauermann@linaro.org> References: <20240426014626.1668298-1-thiago.bauermann@linaro.org> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Thu, 25 Apr 2024 22:46:26 -0300 Thiago Jung Bauermann wrote: > Test behaviour of watchpoints triggered by libc's memset/memcpy/memmove. > These functions are frequently optimized with specialized instructions > that favor larger memory access operations, so make sure GDB behaves > correctly in their presence. > > There's a separate watched variable for each function so that the testcase > can test whether GDB correctly identified the watchpoint that triggered. > > Also, the watchpoint is 28 bytes away from the beginning of the buffer > being modified, so that large memory accesses (if present) are exercised. > > PR testsuite/31484 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31484 > --- > > Changes in v4: > - Also accept memmove symbol for memcpy watchpoint test (Suggested by Kevin). > > Changes in v3: > - Reworked "continue until memset/memcpy/memmove watchpoint hits" tests to > have a chance to work even without libc debug info (Suggested by Kevin). > - Dropped "require libc6_has_debug_info" call (Suggested by Kevin). > > Changes in v2: > - Ensure watchpoints are aligned to 4 bytes. > - Add kfail for arm-linux. LGTM, plus I didn't find any problems while testing on Fedora 39 x86_64, both with and without debuginfo. Approved-by: Kevin Buettner