Re: [PATCHv4 13/14] gdb: allow quoted filenames for commands that have custom completion

Eli Zaretskii
2024-07-04T15:43:08Z

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Thu, 4 Jul 2024 15:21:08 +0100
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -23,6 +23,13 @@ remove-symbol-file -a ADDRESS
> multiple terms, e.g. 'function + 0x1000' (without quotes),
> previously only a single term could be given.
>
> +compile file
> +maint print c-tdesc
> +save gdb-index
> + These commands now require their filename argument to be quoted if
> + it contains with white space or quote characters. If the argument
^^^^
The "with" part should be removed.

Also, are white space and quotes the only special characters for these
commands?

> + contains no special characters then quoting is not required.
^^^^^^^^^^^^^^^^^^^^^
I suggest to say here "no such special characters", to make absolutely
clear that you are talking about white space and quotes mentioned
earlier by their names.

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>