From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QNdiMAEWBWYeLBkAWB0awg (envelope-from ) for ; Thu, 28 Mar 2024 03:02:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=tYcjXBCR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B63DE1E0C0; Thu, 28 Mar 2024 03:02:25 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 817B61E030 for ; Thu, 28 Mar 2024 03:02:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 11228385C6EE for ; Thu, 28 Mar 2024 07:02:23 +0000 (GMT) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 709803858C36 for ; Thu, 28 Mar 2024 07:01:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 709803858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 709803858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711609292; cv=none; b=AOxJm/6ir7rPfr6qZvWVscd6FgiHzrbSZ8jIr8b8tRsyE3dOMaSAm2gBL1TonH7rHWecW6ngJIEPFPap6ihWyHvAQjMF6ZILE0b04585r24yWv6grD5nZd1+hy5DnoNdrL10zRtNLVrhLOO+zCinUrP26U1rWKLMWwOzkW8lyso= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711609292; c=relaxed/simple; bh=cw8HWoi0GK9IULJ9tjjvNvNLD3bq4hT65KiMLi9O98c=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=k/xh85h38bewXf1QYyKESlKqYpPNKGBusEbh5oSpwwHtcztKiJdS/63zcv3C7jAAfuc1jTgKEndihb/p1/J40BtEf1dTEhT07rRhoGYJ/6w08RhGROn7UkKEzYCG/uMkG3aTSvPvdsXfN9oHRTmVa+W0KDqN0BU+eBum/vvcHfw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1df01161b39so5612415ad.3 for ; Thu, 28 Mar 2024 00:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711609289; x=1712214089; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nFpODmsS60D0MgO2Sq0vHP1Bf80f04kJ09zfTtn5e6M=; b=tYcjXBCRUiqpeFRHXmEyheiNDQ6yNLueTyi8JAlS0O1p3URrwk7TSIyzz1DiayG2lU eXm0bSizk9MRFSOmHKCrPS7OccKzRkMvP2mcGqbvLlwCtXscmYXbJi4VIEG/4s6OhDiZ hQi9uRyv27OVu/5U9HDOlXYOUbo+cZt+oqisZb2qGXzchxCtmKTWnq1xSu11ygWzyohz QscqJuLt3lrHJf6w22k9mpa7gAbXCA0uPYdndAjUvkDoeNI5wet8n8PXaMTxKb62Sxwx qYtfakyObTy1QavIdcsyxgWm7+S4e2sOn/UG+hD3G7VHbLvwWgyN5q3CwKEHAA7IXOly UYJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711609289; x=1712214089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nFpODmsS60D0MgO2Sq0vHP1Bf80f04kJ09zfTtn5e6M=; b=rf8Y5dogFT1dyUUHonIRZEM1D4j7VEmb4iHpn5D4BvY0VjHiJMvWuxS8tZcJa2J2PI xPN8yd5Ul2Z0gsev3gWnBv5nmLUQK9kB8CX29ETEDLlM6pbILy5jUgEXSomS2ftF7Rn0 Fmvmu0XRGeexrLpSXSUVvgpU4X7qVGe9oxv9/jePrhHpIz1Zs8gN6949mzNM4/lIhU+z Il4N3p+0Vp82wYVNYYVSBsEqZ9dEZsJXvEoRy7q3upFcF6hx6v+nsWyRhL4JyK+DICmg gTldkjSlZ/tP/Gvgfl4jXBbdaP8CE0RDHG40zueNp1qtjAd+RCVzsNeP6bQ05ZwS/dJ+ m1kA== X-Gm-Message-State: AOJu0YyuvBtRD+1/dbRmNEZtEzlDtRTHPXzKJ409ZQxcGPZPlsLatPPv fB5vNTszsuSlnXPe+QUZ35SSuHFsedLebu71Zdk1X/CTHJqg/JhlH+oBzGt2EppLrKm0deHnbWb G X-Google-Smtp-Source: AGHT+IEijJGr0s2GwznyEEPAfSq84fzZPN89KVyS0WqvelJMhsUD/fn73kUFpU7ksgLe069gGe6BGQ== X-Received: by 2002:a17:902:6808:b0:1e0:e2b1:7395 with SMTP id h8-20020a170902680800b001e0e2b17395mr1864703plk.14.1711609289205; Thu, 28 Mar 2024 00:01:29 -0700 (PDT) Received: from amd.. ([2804:7f0:b402:41b2:3e7c:3fff:fe7a:e83b]) by smtp.gmail.com with ESMTPSA id b15-20020a170902650f00b001e014627baasm754252plk.79.2024.03.28.00.01.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 00:01:28 -0700 (PDT) From: Gustavo Romero To: gdb-patches@sourceware.org Cc: luis.machado@arm.com, thiago.bauermann@linaro.org, gustavo.romero@linaro.org Subject: [PATCH 1/4] gdb: aarch64: Remove MTE address checking from get_memtag Date: Thu, 28 Mar 2024 07:00:52 +0000 Message-Id: <20240328070055.2578783-2-gustavo.romero@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240328070055.2578783-1-gustavo.romero@linaro.org> References: <20240328070055.2578783-1-gustavo.romero@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org This commit removes aarch64_linux_tagged_address_p from aarch64_linux_get_memtag. aarch64_linux_tagged_address_p checks if an address is tagged (MTE) or not. The check is redundant because aarch64_linux_get_memtag is always called from the upper layers (i.e. from printcmd.c via gdbarch hook gdbarch_get_memtag) after either gdbarch_tagged_address_p (that already points to aarch64_linux_tagged_address_p) has been called or after should_validate_memtags (that calls gdbarch_tagged_address_p at the end) has been called, so the address is already checked. Hence: a) in print_command_1, aarch64_linux_get_memtag (via gdbarch_get_memtag hook) is called but only after should_validate_memtags, which calls gdbarch_tagged_address_p; b) in do_examine, aarch64_linux_get_memtag is also called only after gdbarch_tagged_address_p is directly called; c) in memory_tag_check_command, gdbarch_get_memtag is called -- tags matching or not -- after the initial check via direct call to gdbarch_tagged_address_p; d) in memory_tag_print_tag_command, address is checked directly via gdbarch_tagged_address_p before gdbarch_get_memtag is called. Also, because after this change the address checking only happens at the upper layer it now allows the address checking to be specialized easily per target, via a target hook. Signed-off-by: Gustavo Romero --- gdb/aarch64-linux-tdep.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index 0b9784f38e4..50055ac3f48 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -2575,10 +2575,6 @@ aarch64_linux_get_memtag (struct gdbarch *gdbarch, struct value *address, tag = aarch64_mte_get_ltag (addr); else { - /* Make sure we are dealing with a tagged address to begin with. */ - if (!aarch64_linux_tagged_address_p (gdbarch, address)) - return nullptr; - /* Remove the top byte. */ addr = gdbarch_remove_non_address_bits (gdbarch, addr); std::optional atag = aarch64_mte_get_atag (addr); -- 2.34.1