From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uC8uIcKE/GV3lxAAWB0awg (envelope-from ) for ; Thu, 21 Mar 2024 15:04:34 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=DjZ3cGvt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 82E531E0C0; Thu, 21 Mar 2024 15:04:34 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 730E71E08C for ; Thu, 21 Mar 2024 15:04:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 37F273858418 for ; Thu, 21 Mar 2024 19:04:32 +0000 (GMT) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id 95F963858D28 for ; Thu, 21 Mar 2024 19:03:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 95F963858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 95F963858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711047816; cv=none; b=nyJDaVk3rtk7Mdqj94WutVIo4wXKVjSp6E+ZVFaGdYz5CJYs0fDmrJN0bc8r9SvjmvMM5nXWGWGA2CN59hpLi6DJg+zCPnK1FN/Csyzdz1JBzrxPJ+4VzvRgrNGmMnTM/W7dt74lMry7HNJODrzNwu/h2frLsjT18uVCHq4J8PM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711047816; c=relaxed/simple; bh=MrjVYRSWxYO11himSbPbYOphhbW0d5JhlpHc8KnC81E=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=Lmu0Jl9OLPnAm87ei/nCHBPPqgNM/tXuT6lvRCsNInWMk4Pc3RWu6/ch9ato7JFyaTSPWvnzfzsT+u+eXSb3gvU2NY1EuU5qiTepLJvk6nOaiGQIaAB2iUQJCM+8JY9tzGOvjPgZqjnJQqvxPW1YsCu08anZXG4WIq/SNlmIWZY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7c8ad87b2acso41597539f.3 for ; Thu, 21 Mar 2024 12:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1711047810; x=1711652610; darn=sourceware.org; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:from:to:cc:subject:date:message-id:reply-to; bh=6klWSBenmZatZAfZs/WYCvyoc79zA4c9WkgxlvJJdEI=; b=DjZ3cGvte7wDKbO4/2LtEOo8QDcjp+SODD18pBMUkVz1OSqWmpLfkZ9lHUMH5w6tX8 wWDpJa3ravCUWDYbpS+hLQ/Dt4V92/lWTIJzAqDPaFFTL7fZmlLrDLcqGJ4LTstAv3Hz sYgCO5xo51ksMzZErA+OjAueK36NDPtbdDA9x/6CDk7GVsxCImx8XLoTXtZo2o/rnYHR nvOb/ap1uV+AYQ5+NgWdiHRqeSm5gOoCS4fGcVDpKLSKdIgmpZiOTmloaZW48WzanPuM /VSLDVzimcMJgw5NbtdQw19sE2qH0Ymu2xMpWNZPdAmTTtFRD/TtYqeCnZiqu9zTmzUE 9+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711047810; x=1711652610; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6klWSBenmZatZAfZs/WYCvyoc79zA4c9WkgxlvJJdEI=; b=b/+FQheZH5uysgTe7hkfRoXY/MmRFr+ZKhI4E7NPctKvVncExtjPv4XQTrNBJAu/px zofUE0bepOnCGw7AC0T3rgTdzLkzgOZIp6OFN4FWW0RoYeNAkzqbhXIo/+56vnNnFa9n G744GJBQ6hS+O6OX813/HJMWqlJr60yZzGowfudSTOSOUc34FYdFK/7jhtqh4Ry+DVMg r7Yp+qcECqKoJTPUYtKrJpqy1y6yI+Qv39+Iw4vBTYNehShSXIYb7dXUsSg0ae+3xwp7 zLwg12rWS2fs8Dpqq0/2ARkB5EEW6syQffW6QLCscqOgdoTytNN54Tkt2PUs8gBWnhpb lSSA== X-Gm-Message-State: AOJu0YyLX2twepsAbfRG3n8nMNqUhPtbBoqdEJ/aVC/QXSP8Ao/jJ6bq 6LYyiQtOmjCFO8ZJjBRcBtFosgxyKmns7sZhh61obfM6jvSuLabfx0ZOQxbTPiAUzsXhx6V3YMc = X-Google-Smtp-Source: AGHT+IEi/wWb8NykD9Fq9hEvDFs6Alffa70IuG1kG0cF9dUKJ3ICWmYrmrkOS78EzQ9eBLwRUNrs4Q== X-Received: by 2002:a5d:8c95:0:b0:7cf:1dcc:ab7 with SMTP id g21-20020a5d8c95000000b007cf1dcc0ab7mr390140ion.12.1711047809845; Thu, 21 Mar 2024 12:03:29 -0700 (PDT) Received: from localhost.localdomain (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id dp10-20020a0566381c8a00b00476f2bfc3f8sm53358jab.87.2024.03.21.12.03.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 12:03:29 -0700 (PDT) From: Tom Tromey Subject: [PATCH 00/12] Ada iterated assignment, plus parser cleanups Date: Thu, 21 Mar 2024 13:03:28 -0600 Message-Id: <20240321-ada-iterated-assign-v1-0-925cdd4f1f4a@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAICE/GUC/x3MQQrCQAxG4auUrA10pkXBq4iLf5rYZuEokyKF0 rsbXX6L93ZybaZO126nph9ze9VAOnU0LaizskmYcp/HfsiJIWBbtWFVYbjbXFkwpnxBGeQsFOW 76cO2//V2Dxe4cmmo0/J7PeExoOP4Al3cTld+AAAA To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org This series implements the Ada 2022 iterated assignment feature. An earlier version of the patch failed to clear a new global in the parser, so I also ended up tacking on a series to make sure this problem can't happen again -- all parser state is moved into a new object. (All the parsers should do this, or go further and follow Rust into recursive descent, IMNSHO.) Tested on x86-64 Fedora 38. This has also been running inside AdaCore for a while now. --- Tom Tromey (12): Introduce and use aggregate_assigner type Implement Ada 2022 iterated assignment Introduce ada_parse_state Move "int_storage" global into ada_parse_state Move "components" and "associations" into ada_parse_state Move "assignments" global into ada_parse_state Move "iterated_associations" into ada_parse_state Move "temp_parse_space" into ada_parse_state Move "paren_depth" into ada_parse_state Move "returned_complete" into ada_parse_state Remove "numbuf" global Constify ada-lex.l:attributes gdb/ada-exp.h | 165 ++++++++++++++----- gdb/ada-exp.y | 212 ++++++++++++++++--------- gdb/ada-lang.c | 202 +++++++++++++---------- gdb/ada-lex.l | 48 +++--- gdb/testsuite/gdb.ada/iterated-assign.exp | 37 +++++ gdb/testsuite/gdb.ada/iterated-assign/main.adb | 24 +++ gdb/testsuite/gdb.ada/iterated-assign/pck.adb | 23 +++ gdb/testsuite/gdb.ada/iterated-assign/pck.ads | 26 +++ 8 files changed, 509 insertions(+), 228 deletions(-) --- base-commit: 7e949f08700b077b78e955c653eb4e9455027101 change-id: 20240321-ada-iterated-assign-da4127ab3d6d Best regards, -- Tom Tromey