From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EXDPCbie6WVFFjwAWB0awg (envelope-from ) for ; Thu, 07 Mar 2024 06:02:16 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=bIK4A0H5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 16D101E0D2; Thu, 7 Mar 2024 06:02:16 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CC77E1E092 for ; Thu, 7 Mar 2024 06:02:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 823423857703 for ; Thu, 7 Mar 2024 11:02:12 +0000 (GMT) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by sourceware.org (Postfix) with ESMTPS id E2FEF3857814 for ; Thu, 7 Mar 2024 11:01:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2FEF3857814 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E2FEF3857814 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.94.58 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709809309; cv=pass; b=NruY+6bMiM+8u+S0lEVNoNA5QMUBVpH2fUWE3mXsuitfpwV6R+PnT8lo0HaONLEzqyeCwJVvSS/56rfTjVUI7xwIynXw4/9bl45Dxt+Svq27Pi/Sny/47z3aadjELfqY/nnveOx6xO6i5gTPXpFezJERzgOYs20cJixioZJc8Yo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709809309; c=relaxed/simple; bh=Z24qO/KYpAZluwzqo5tc0K5v8PyY7taVja63buyWj84=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=NNeLCh0G3nrXTCFYfKoCtPb2SzR8Jkdtn/PGIe9IcT9MZNi+yvHHRvs/sFgmhLroLt3KxcKorJpnBnid+UA5LNJP/Sh8rWBmpHt42Jl0ysWw1gQNWLNOYCdqpIVbBL3g/3s5CWiieLyFogbDf44zoc6L6+mJNG6kNOq5pNF4HU0= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EHgmgIiVvDXK/GxWhfIBP7U/zJCZFZlsPb0Y05UnZGSW2zPIl60bv5OBvtLhUP20fY6GBKm5iy6Y8USbr1fgy9fByIdoDVyIZmXliwZbZFfYGsVP6KfIoYFPsk+B5Rlj8iR+xVXOilVfGQy4bbfZy5tpVW/n/Q0MDtLidm30vGVd6lzDVztlAjsBxsblVSMh53a5EZOztqQJsBbUtaoSBEiA7q8K68evNnQ+HP/Do8Pow6P+sXNnfUI60Eg2g9iA7k1d6dj1jkIuHvfXeivUbS+O8pXnl7WMie7AfbvHDksuio3YDd8uxFwLSBFU33DGGsNPMF8OnFKtxgJdTMVfzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wAtyVDqWrDFEvuboBBKnUzJPnQDKdw36DViZNV5tZXY=; b=ix3uCsCTLPxsCcZC1pFc160PfzN6Lrv25ApKSYN2KNvHQxm9H/kVFZqoJ2iGhfS+Dors2tiQkFbk9JyD5QL4pH3PVIUsxRlVSgw0uVrZdjIxcwz2VQgnqJv65oH6SkGnTEcy2N7OWU4jXkBxI6EJgIBjqaj8fnZTiujaNydTw3Fpj/WHy4+Gkql94GRdwXwbsXdAfk0fknu+FuZknlbwMW8GHDQ+x+icZfi+0lfNAcpJsqu3z/C4JqbxcIzkIiOCYLGyvP02xoIs++/PX6ZUOqBp283Rh1kPqACowAHyDQUsbcGm6O7nMoKBJTZeN6Ds2aNFpxgdT70TOHbLVcuaTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wAtyVDqWrDFEvuboBBKnUzJPnQDKdw36DViZNV5tZXY=; b=bIK4A0H599la8DXGvhlXU3/RTTiHJQVX/KaRsOKicHqgCNnnEQX+X3geHuvvi51O7H2Kseoxnll0TwCj6LTfsSsS639LmsaCBw5KrLVsJl3IGpw0HtguSj+g8CVB827YLS4wiqUUaiQ80ykbh/WNiAxYNrQvlt6EyNdxKFF3VkY= Received: from SJ0PR05CA0142.namprd05.prod.outlook.com (2603:10b6:a03:33d::27) by SJ1PR12MB6268.namprd12.prod.outlook.com (2603:10b6:a03:455::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Thu, 7 Mar 2024 11:01:43 +0000 Received: from SJ5PEPF000001D3.namprd05.prod.outlook.com (2603:10b6:a03:33d:cafe::94) by SJ0PR05CA0142.outlook.office365.com (2603:10b6:a03:33d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24 via Frontend Transport; Thu, 7 Mar 2024 11:01:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001D3.mail.protection.outlook.com (10.167.242.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7362.11 via Frontend Transport; Thu, 7 Mar 2024 11:01:43 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Mar 2024 05:01:40 -0600 Date: Thu, 7 Mar 2024 11:01:33 +0000 From: Lancelot SIX To: Guinevere Larsen CC: Subject: Re: [PATCH 3/4] gdb: Migrate frame unwinders to use C++ classes Message-ID: <20240307110133.lhu7kcqvmqnxmmw2@khazad-dum> References: <20240306125135.766567-1-blarsen@redhat.com> <20240306125135.766567-4-blarsen@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240306125135.766567-4-blarsen@redhat.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D3:EE_|SJ1PR12MB6268:EE_ X-MS-Office365-Filtering-Correlation-Id: ba8c0a42-66c8-45b9-5b69-08dc3e95f934 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f9agilptBFN3X2YLpX8PxENeM6Tu6CQbPAhtpnCungtM28PjEsX6ZSpcuP3PUXa7rNwYAfnRGcRfuz3l+r9skjGnZsdJs7xxJM6fAT2Mro03PHXChJPRsPDIkdjeu/rq6C+kh1zIPO2Gc/bn5EgK8RwCr3Pf/kvjJv6tCDYe8FJcX3G99tCXve8UllmI4qxGEIUa4n4z6+TovuLuN5P+3/9iX0S1UKaXcyGl/EEM0J7mqfnlysCCtB1V3ASPnxMRUv0c8KnL0d4j6RKwuNoZGacp60Cg2vZT8crbKc950e4rGPK88fqCRg4UKnhxJsX2YrgpAu5qWXZCj2XmG4DLjluqC9rUtV7DYM48EUapJcRYY7LN5b4MoBdqHdBrtuRC7C/1/jKN0pPhbfXQCb+vIaeZpR3p8t9Ljfy2ZvFkw/JmHqUS+j0oo8Nvm5Fwlgh6RsFmzUnWguE5oj/jomKoY2+6rfAVyUzt4u4XykHGu1lTY26ySrgUR8OHKRDzvds2zqBTDX5kCVu/RfJ5KwkZw/rb/dgrKXz3bqwsHeGb3xoI9TXGCOnOyf2J9bRUdxj0mG2VoRSR6QbZAvPLQ1OQOLk5b4q8Mo60RcyqHNI0Jn4Ueo9iAzwtPVsCBtborIvm3Q+3ZVx06qIYt8y31QaLXmP9fCliQEG8smYM+zMqmaFZkQNDlJMjOcc2RFRJqnMF0/Dlo6hdXMRgODuMazLNODrx68JXzSBMXAGHAChlbR+KjDn37phnYrazHxVPfyT5 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(82310400014)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 11:01:43.0525 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba8c0a42-66c8-45b9-5b69-08dc3e95f934 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6268 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Wed, Mar 06, 2024 at 01:51:34PM +0100, Guinevere Larsen wrote: Hi Gwen, I have not read the specific of this series, but testing the patches as is causes a build failure on amdgpu-tdep.c > diff --git a/gdb/amdgpu-tdep.c b/gdb/amdgpu-tdep.c > index 8189de8e565..45c83a562e8 100644 > --- a/gdb/amdgpu-tdep.c > +++ b/gdb/amdgpu-tdep.c > @@ -892,7 +892,7 @@ amdgpu_frame_prev_register (const frame_info_ptr &this_frame, void **this_cache, > return frame_unwind_got_register (this_frame, regnum, regnum); > } > > -static const frame_unwind amdgpu_frame_unwind = { > +static const frame_unwind_legacy amdgpu_frame_unwind ( > "amdgpu", > NORMAL_FRAME, > FRAME_UNWIND_ARCH, > @@ -903,7 +903,7 @@ static const frame_unwind amdgpu_frame_unwind = { > default_frame_sniffer, > nullptr, > nullptr, ^ Moving from the aggregate initializer to a regular constructor call, this last coma must be removed. With this fixed, I tested this series on the gdb.rocm/*.exp part (both on upstream GDB and our downstream port) and see no regression. I'll try to actually read the actual later. Best, Lancelot. > -}; > +); > > static int > print_insn_amdgpu (bfd_vma memaddr, struct disassemble_info *info) > > -- > 2.43.2 >