Re: [PATCH 4/4] GDB: introduce ability to disable frame unwinders

Eli Zaretskii
2024-03-06T14:16:57Z

> Date: Wed, 6 Mar 2024 15:07:17 +0100
> Cc: gdb-patches@sourceware.org
> From: Guinevere Larsen <blarsen@redhat.com>
>
> >> +The meaning of the argument @samp{unwinder} depends on the @samp{option}
> > The correct markup here is @var, not @samp, since these are not
> > literal symbols, but instead names of parameters that stand for
> > something else. Likewise elsewhere in the gdb.texinfo part of the
> > patch.
>
> Ah, thanks for explaining! Should I also change the @samp in the table
> section?

Only for @samp{unwinder} and @samp{option}. The rest are literals,
like "-all".

> >> +The class may include the prefix @code{FRAME_UNWINDER_}, but it is not
> >> +required. This is the default option.
> > What do you mean by the last sentence? What is "this" that is the
> > default option? And what does "default" mean for an option, since an
> > option is by definition something that doesn't happen by default.
>
> option is an optional parameter, and if the user decides to not provide
> it, the command will work as if the user had provided the -class option.

Then I suggest to rephrase like this:

By default, @var{unwinder} is interpreted as a class, even if
@samp{-class} was omitted.