Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>
To: gdb-patches@sourceware.org
Cc: abdul.b.ijaz@intel.com, markus.t.metzger@intel.com, blarsen@redhat.com
Subject: [PATCH 0/1] update btrace tests to test all recording methods
Date: Mon,  4 Mar 2024 09:23:53 +0100	[thread overview]
Message-ID: <20240304082354.3336-1-abdul.b.ijaz@intel.com> (raw)

From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>

Fixes the feedback from Larsen and Markus in V2 patch.

Changes since V1:

1) Keep the function name allow_btrace_tests for checking if btrace tests
are allowed.
2) Update the allow_btrace_tests function to test both btrace recording
methods support and return 0 if both of them are not supported.
3) Remove unnecessary changes  to add "allow_btrace_pt_tests" calls for
btrace related tests in gdb.python folder.
4) Since the function body of "allow_btrace_pt_tests" and
"allow_btrace_pt_tests" is similar so caching functions are still kept
but the function body is copied to common function as per the feedback.

The feedback regaring gdb.btrace/tsx.exp test is not updated because of
the reason mentioned here:
https://sourceware.org/pipermail/gdb-patches/2024-February/206617.html

V1 patch can be found here:
https://sourceware.org/pipermail/gdb-patches/2024-February/206529.html

Thanks & Best Regards,
Abdul Basit

Ijaz, Abdul B (1):
  testsuite, btrace: update btrace testsuite to test all btrace
    recording methods

 gdb/testsuite/gdb.btrace/buffer-size.exp      |  37 +-
 gdb/testsuite/gdb.btrace/data.exp             |  64 +--
 gdb/testsuite/gdb.btrace/delta.exp            | 102 +++--
 gdb/testsuite/gdb.btrace/dlopen.exp           |  37 +-
 .../gdb.btrace/enable-new-thread.exp          |  35 +-
 gdb/testsuite/gdb.btrace/enable-running.exp   |  59 +--
 gdb/testsuite/gdb.btrace/enable.exp           | 153 ++++---
 gdb/testsuite/gdb.btrace/exception.exp        | 103 +++--
 .../gdb.btrace/function_call_history.exp      | 414 +++++++++---------
 gdb/testsuite/gdb.btrace/gcore.exp            |  34 +-
 .../gdb.btrace/instruction_history.exp        | 303 ++++++-------
 gdb/testsuite/gdb.btrace/multi-inferior.exp   |  62 +--
 .../gdb.btrace/multi-thread-step.exp          | 106 ++---
 gdb/testsuite/gdb.btrace/nohist.exp           |  30 +-
 gdb/testsuite/gdb.btrace/non-stop.exp         | 305 ++++++-------
 gdb/testsuite/gdb.btrace/reconnect.exp        |  94 ++--
 gdb/testsuite/gdb.btrace/record_goto-step.exp |  39 +-
 gdb/testsuite/gdb.btrace/record_goto.exp      | 310 ++++++-------
 gdb/testsuite/gdb.btrace/rn-dl-bind.exp       |  61 +--
 gdb/testsuite/gdb.btrace/segv.exp             |  40 +-
 gdb/testsuite/gdb.btrace/step.exp             |  48 +-
 gdb/testsuite/gdb.btrace/stepi.exp            | 205 ++++-----
 gdb/testsuite/gdb.btrace/tailcall-only.exp    |  92 ++--
 gdb/testsuite/gdb.btrace/tailcall.exp         | 133 +++---
 gdb/testsuite/gdb.btrace/tsx.exp              |   2 +-
 .../gdb.btrace/unknown_functions.exp          |  66 +--
 gdb/testsuite/gdb.btrace/vdso.exp             |  34 +-
 .../gdb.python/py-record-btrace-threads.exp   |  75 ++--
 gdb/testsuite/lib/gdb.exp                     | 124 +++---
 29 files changed, 1689 insertions(+), 1478 deletions(-)

-- 
2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


             reply	other threads:[~2024-03-04  8:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04  8:23 Abdul Basit Ijaz [this message]
2024-03-04  8:23 ` [PATCH 1/1] testsuite, btrace: update btrace testsuite to test all btrace " Abdul Basit Ijaz
2024-03-26  9:16   ` Metzger, Markus T
2024-04-09  9:54     ` Metzger, Markus T
  -- strict thread matches above, loose matches on Subject: below --
2024-02-12 16:26 [PATCH 0/1] update btrace tests to test all " Abdul Basit Ijaz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240304082354.3336-1-abdul.b.ijaz@intel.com \
    --to=abdul.b.ijaz@intel.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox