From: Lancelot SIX <lsix@lancelotsix.com>
To: Felix Willgerodt <felix.willgerodt@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/1] gdb: Document C++17 build requirement.
Date: Mon, 19 Feb 2024 18:13:49 +0000 [thread overview]
Message-ID: <20240219181349.2olvcmvt7mwyldmt@octopus> (raw)
In-Reply-To: <20240219145655.1833203-1-felix.willgerodt@intel.com>
Hi Felix,
Thank for catching this, I missed that part of the documentation when
doing the C++17 migration.
I have updated the wiki to reflect the C++17 requirement.
Reviewed-By: Lancelot Six <lancelot.six@amd.com>
Best,
Lancelot.
On Mon, Feb 19, 2024 at 03:56:55PM +0100, Felix Willgerodt wrote:
> We require C++17 to build for a while now:
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f74dc26792a0679e29db45e56367331ff48666d1
>
> I also found another place we probably should update:
> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#C.2B-.2B-_dialect
> But I don't know how to do that.
>
> ---
> gdb/doc/gdb.texinfo | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index e4b89cfccfc..79805486dd6 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -40555,9 +40555,9 @@ Other packages will be used only if they are found.
>
> @heading Tools/Packages Necessary for Building @value{GDBN}
> @table @asis
> -@item C@t{++}11 compiler
> -@value{GDBN} is written in C@t{++}11. It should be buildable with any
> -recent C@t{++}11 compiler, e.g.@: GCC.
> +@item C@t{++}17 compiler
> +@value{GDBN} is written in C@t{++}17. It should be buildable with any
> +recent C@t{++}17 compiler, e.g.@: GCC.
>
> @item GNU make
> @value{GDBN}'s build system relies on features only found in the GNU
> --
> 2.34.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
>
next prev parent reply other threads:[~2024-02-19 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 14:56 Felix Willgerodt
2024-02-19 18:13 ` Lancelot SIX [this message]
2024-02-21 8:39 ` Willgerodt, Felix
2024-02-21 21:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219181349.2olvcmvt7mwyldmt@octopus \
--to=lsix@lancelotsix.com \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox