Re: [PATCH v3 1/2] gdb/testsuite: fix gdb.threads/threadcrash.exp on 32-bit arm targets

Tom de Vries
2024-03-08T10:01:43Z

On 2/14/24 10:17, Guinevere Larsen wrote:
> -test_gcore
> +if { [is_aarch32_target] } {
> + kfail "gcore tests fail on 32-bit arm, see PR corefiles/31294"
> +} else {
> + test_gcore
> +}

The xfail and kfail procs don't have the same args:
...
$ egrep -d skip "proc (xfail|kfail)" /usr/share/dejagnu/*
/usr/share/dejagnu/framework.exp:proc xfail { message } {
/usr/share/dejagnu/framework.exp:proc kfail { bugid message } {
...
and consequently this patch runs into an error.

Furthermore, I don't run into the reported problem on my setup (pinebook
aarch64 manjaro, chroot debian 32-bit), so this style of kfail actually
prevents me from successfully running the tests.

I proposed a more precise fix in v4, though I can't test it ...

Thanks,
- Tom