Re: [PATCH v3 1/2] gdb/testsuite: fix gdb.threads/threadcrash.exp on 32-bit arm targets

Tom de Vries
2024-03-08T12:25:46Z

On 3/8/24 11:01, Tom de Vries wrote:
> On 2/14/24 10:17, Guinevere Larsen wrote:
>> -test_gcore
>> +if { [is_aarch32_target] } {
>> +    kfail "gcore tests fail on 32-bit arm, see PR corefiles/31294"
>> +} else {
>> +    test_gcore
>> +}
>
> The xfail and kfail procs don't have the same args:
> ...
> $ egrep -d skip "proc (xfail|kfail)" /usr/share/dejagnu/*
> /usr/share/dejagnu/framework.exp:proc xfail { message } {
> /usr/share/dejagnu/framework.exp:proc kfail { bugid message } {
> ...
> and consequently this patch runs into an error.
>

And ... I just realized I made the same mistake in v4. I already
spotted another mistake, I intended to bail out after the kfail and
forgot to add that. I'll follow up on the patch once it arrives on the ml.

Thanks,
- Tom

> Furthermore, I don't run into the reported problem on my setup (pinebook
> aarch64 manjaro, chroot debian 32-bit), so this style of kfail actually
> prevents me from successfully running the tests.
>
> I proposed a more precise fix in v4, though I can't test it ...
>
> Thanks,
> - Tom