Re: [PATCH v3 2/2] gdb/testsuite: reduce gdb.threads/threadcrash.exp reliance on libc symbols

Tom de Vries
2024-03-07T23:17:21Z

On 3/7/24 10:11, Guinevere Larsen wrote:
> On 06/03/2024 18:16, Tom de Vries wrote:
>> On 2/14/24 10:17, Guinevere Larsen wrote:
>>> The test gdb.threads/threadcrash.exp demanded GDB to fully unwind and
>>> print the names of all functions. However, some of the functions are
>>> from the libc library, and so the test implicitly demanded libc symbols
>>> to be available, and would fail otherwise, as was raised in PR
>>> gdb/31293.
>>>
>>> This commit changes it so we only explicitly check for functions that
>>> are provided by threadcrash.c to fix that
>>
>> Hi Gwen,
>>
>> Nit: Missing dot at end of line.
>>
>> With that fixed, LGTM.
>>
>> Approved-By: Tom de Vries <tdevries@suse.de>
>
> Thanks for the review!
>
> Would this apply to both patches or just this second one?
>

Just this one, but after looking at the other patch, I realize also this
patch is not ideal: if there are libc symbols for sleep and pthread_kill
in the live_inferior case, they also should be there for the other cases.

I'm working on a patch series based on yours, addressing this and a few
more issues, hoping to submit tomorrow.

Thanks,
- Tom