Re: [PATCH v2 10/30] Use a .def file for domain_enum

[Lancelot SIX <lsix@lancelotsix.com>]

On Thu, Jan 18, 2024 at 01:32:08PM -0700, Tom Tromey wrote:
> Future patches will change and reuse the names from domain_enum.  This
> patch makes this less error-prone by having a single point to define
> these names, using the typical gdb ".def" file.
> ---
>  gdb/guile/scm-symbol.c | 18 ++++++++++--------
>  gdb/python/py-symbol.c | 21 ++++++++-------------
>  gdb/sym-domains.def    | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  gdb/symtab.c           | 10 ++++------
>  gdb/symtab.h           | 31 +++----------------------------
>  5 files changed, 72 insertions(+), 55 deletions(-)

Hi Tom,

FYI, starting this patch I have a CI box running centos-7 which fails
with:

    In file included from ../../gdb/tui/tui-source.c:25:
    ../../gdb/symtab.h:897: error: "DOMAIN" redefined [-Werror]
      897 | #define DOMAIN(X) X ## _DOMAIN,
          | 
    In file included from /opt/rh/devtoolset-9/root/usr/include/c++/9/cmath:45,
                     from /opt/rh/devtoolset-9/root/usr/include/c++/9/math.h:36,
                     from ../gnulib/import/math.h:41,
                     from ../../gdb/tui/tui-source.c:23:
    /usr/include/math.h:332: note: this is the location of the previous definition
      332 | # define DOMAIN  1
          | 

The DOMAIN macro used to call the .def conflicts with the one from
/usr/include/math.h (glibc-1.17, so yeah, quite old).

A fix can be to use DOMAIN_ (or SYM_DOMAIN any better name) in
sym-domains.def.  Do you have a preferred name?

Best,
Lancelot.