From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id x9eeD/6tqmU13gAAWB0awg (envelope-from ) for ; Fri, 19 Jan 2024 12:14:38 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JLooWCX8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 343181E0C3; Fri, 19 Jan 2024 12:14:38 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 165E91E092 for ; Fri, 19 Jan 2024 12:14:36 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AFBED385840D for ; Fri, 19 Jan 2024 17:14:35 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9F1B63858C78 for ; Fri, 19 Jan 2024 17:14:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F1B63858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F1B63858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705684451; cv=none; b=bEdAJ6OB/EbMhy49V29bxGo/4ep8+iindWPvFx8yRn3es7aGOdr9XOEkS97LJMQffjSS2aI6RWR7Z7U2Mw3ajqMk2kclVjsyavSq8F3LQt9NVvJP9nV0qcNdh8Z2EJ8YnVUkNKPRi+ztvGOmOODjE5Ip1j/9kPwfCQBn0NPpTQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705684451; c=relaxed/simple; bh=PuyAgiiKNcLFrAgyb/C1gsPrBaRIVEXWKWGPSNlfbc4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=mewP2UGT0ogxaK2fZJ14VK2S0rqLdWNORc6TY8qyOGRueFhTgS+2HJPkx7OBUZiNxO6x9g7/H9jDzAmhPPzwYjdvlwg5cswQ66QrImvDfWdpPDKWvgQcBk1ZemVkv35gG2LkXNl0IZLeuHGGo9cqBNCDfg2gExO3ruWSPL28ses= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705684449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GV9Emd3tNAUSse6H+Cklf1NjYs540rKMJPpPn8l/zzE=; b=JLooWCX80hWbEqSTlwxEBx6iV7IF0UZSrH0faEo++7dGOUwD4CqfXWROkvA7u8vp8kNpe5 C/a6ccrUqwVaLKXhTbuarNSOfoHDcsPqTsESuLEXAeZqht5CenCBV8P3+wAqUKkV+CxeKJ IgNDuvt/PfKno2yS3FvqERlCCABp8hI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-JQgYheHDMNGNmoLCjI_pPA-1; Fri, 19 Jan 2024 12:14:06 -0500 X-MC-Unique: JQgYheHDMNGNmoLCjI_pPA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C00453C2AB0E; Fri, 19 Jan 2024 17:14:05 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.32.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C1D1494; Fri, 19 Jan 2024 17:14:05 +0000 (UTC) From: Aaron Merey To: luis.machado@arm.com Cc: aburgess@redhat.com, thiago.bauermann@linaro.org, gdb-patches@sourceware.org, Aaron Merey Subject: Re: [PATCH 1/4 v8] gdb: Buffer output streams during events that might download debuginfo Date: Fri, 19 Jan 2024 12:13:46 -0500 Message-ID: <20240119171352.827651-1-amerey@redhat.com> In-Reply-To: <35826cb5-1ff6-4101-9105-ffb9512e7b44@arm.com> References: <35826cb5-1ff6-4101-9105-ffb9512e7b44@arm.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi Luis, On Fri, Jan 19, 2024 at 9:35 AM Luis Machado wrote: > > I bisected a number of failures in gdb.dwarf2/dw2-dir-file-name.exp to commit 519d634396592c5698add4a327468e6e6920576e. > > In particular, my testing was done on aarch64-linux (Ubuntu 20.04). Thanks for finding this. These regressions are due to a last-minute decision to replace throw_exception with throw in one of the functions added in commit 519d634. I'm going to merge the patch below that restores throw_exception. Regression tested on Fedora 39 x86_64. Aaron --- gdb/ui-out.h: Fix exception handling in do_with_buffered_output Replace throw with throw_exeception in do_with_buffered_output. This patch fixes regressions in gdb.dwarf2/dw2-dir-file-name.exp caused by commit 519d63439. do_with_buffered_output needs to use throw_exception instead of throw to ensure that exceptions of the correct type are thrown. If using throw, gdb_exception_error may be wrongly converted into gdb_exception during print_frame_info. This prevents the exception from being caught in print_stack_frame. --- gdb/ui-out.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/ui-out.h b/gdb/ui-out.h index 71add908a84..5b6ddd55063 100644 --- a/gdb/ui-out.h +++ b/gdb/ui-out.h @@ -543,7 +543,7 @@ do_with_buffered_output (F func, ui_out *uiout, Arg... args) { func (uiout, std::forward (args)...); } - catch (const gdb_exception &ex) + catch (gdb_exception &ex) { /* Ideally flush would be called in the destructor of buffer_group, however flushing might cause an exception to be thrown. Catch it @@ -556,7 +556,7 @@ do_with_buffered_output (F func, ui_out *uiout, Arg... args) { } - throw (std::move (ex)); + throw_exception (std::move (ex)); } /* Try was successful. Let any further exceptions propagate. */ -- 2.43.0