From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id b78WHEXMkmWOLTAAWB0awg (envelope-from ) for ; Mon, 01 Jan 2024 09:29:25 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=lancelotsix.com header.i=@lancelotsix.com header.a=rsa-sha256 header.s=2021 header.b=cfiT6wmN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 63CAC1E0C3; Mon, 1 Jan 2024 09:29:25 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 516FE1E0B9 for ; Mon, 1 Jan 2024 09:29:23 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 857903858C35 for ; Mon, 1 Jan 2024 14:29:22 +0000 (GMT) Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id EB3543858D1E for ; Mon, 1 Jan 2024 14:28:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB3543858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB3543858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=51.195.220.111 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704119338; cv=none; b=wjX+SMZ/7+EjSYMuUd4s/o7ysL6Rl0FcjTpIeU1gmURgyiAJj9F8mC/A/r+KQsStzN8QOjmQ7YgY17oOJHJCDi2je+foWWmbg0AdOldv57jYGDth/M5F1sezTwyQfqWVpnD2ek5c0kMIVSzX2mCCVGh7cQruTKaCHpRakcLNl5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704119338; c=relaxed/simple; bh=9+LnrnS9tFM1qDsr116soqOz6jrcTsLc8Jb/3sKREjY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Y5qdsB35YsQn41COjwdPNcABFgCtS1kzKIwiEQwg0vJmSAKt4bj4hgKkl/kBxTiD0nVxub6batnub8nW23sqHiQVaAPXWJvvTJd6goKZCDYr1JFkpJ2bmf4eQYiFjV36FLAVGhdIFNFlqkmAKuH91d7sqZkVBE7KMB/MCvZqSBg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id A848C8115E; Mon, 1 Jan 2024 14:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com; s=2021; t=1704119334; bh=9+LnrnS9tFM1qDsr116soqOz6jrcTsLc8Jb/3sKREjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cfiT6wmNhp5R4Au+88a1uZpPdRmYJQzi6N42qPRAjbk34GlKdd5f7DkDoIa642hDC gu0Q9HYOT+ieEYQkrbHMjhngkqxFayvGRa18PoOpIh1oWQItngpY5Af59dMp4QR7Vr gyIyhhAxqNhWzcelbGjwgPqChtSfJx0ZapwLk8sb/UUqw8jb4kfaW0NhrfKFyGYGyP +aNdXz42hnkPRXoOf/zz8Ijmq63OE2K43pzboxBFqcjMEiM+uQnP8r3U3p3aQuPQM4 MQyYTBiE7IrdtysK4oKiN/9knSuwd2U95bpqCFvd9+KLWLH/qpUsafPLnlFCDtLOdQ /crvkcZxysppw== Date: Mon, 1 Jan 2024 14:28:49 +0000 From: Lancelot SIX To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/6] Make remote-fileio per-target Message-ID: <20240101142822.7uxadorlti6kkf2k@octopus> References: <20231231-remote-fileio-v1-0-249cc6c440d9@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231231-remote-fileio-v1-0-249cc6c440d9@tromey.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Mon, 01 Jan 2024 14:28:54 +0000 (UTC) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi Tom, I went through the series and sent comments on patch 2. Overall this all seem reasonable to me (I have not tested the code). Best, Lancelot. On Sun, Dec 31, 2023 at 01:25:37PM -0700, Tom Tromey wrote: > I noticed that the remote-fileio code uses a global. It seemed to me > that this should be per-target instead. > > After writing this I noticed that gdbserver does not seem to implement > any of these packets. So, I don't think this can really be tested. > > --- > Tom Tromey (6): > Make remote_fio_func_map 'const' > Use vector in remote-fileio.c > Use methods for remote fileio > Remove sentinel from remote_fio_func_map > Move remote_fileio_data to header file > Store remote fileio state in remote_state > > gdb/remote-fileio.c | 248 ++++++++++++++++++++++++---------------------------- > gdb/remote-fileio.h | 42 +++++++-- > gdb/remote.c | 8 +- > 3 files changed, 153 insertions(+), 145 deletions(-) > --- > base-commit: 276e7f5c8835cd300ee75d00556ab8839a30b9ef > change-id: 20231231-remote-fileio-24fbff0ba416 > > Best regards, > -- > Tom Tromey >