Re: [PATCH 0/6] Make remote-fileio per-target

Lancelot SIX
2024-01-01T14:29:25Z

Hi Tom,

I went through the series and sent comments on patch 2. Overall this
all seem reasonable to me (I have not tested the code).

Best,
Lancelot.

On Sun, Dec 31, 2023 at 01:25:37PM -0700, Tom Tromey wrote:
> I noticed that the remote-fileio code uses a global. It seemed to me
> that this should be per-target instead.
>
> After writing this I noticed that gdbserver does not seem to implement
> any of these packets. So, I don't think this can really be tested.
>
> ---
> Tom Tromey (6):
> Make remote_fio_func_map 'const'
> Use vector in remote-fileio.c
> Use methods for remote fileio
> Remove sentinel from remote_fio_func_map
> Move remote_fileio_data to header file
> Store remote fileio state in remote_state
>
> gdb/remote-fileio.c | 248 ++++++++++++++++++++++++----------------------------
> gdb/remote-fileio.h | 42 +++++++--
> gdb/remote.c | 8 +-
> 3 files changed, 153 insertions(+), 145 deletions(-)
> ---
> base-commit: 276e7f5c8835cd300ee75d00556ab8839a30b9ef
> change-id: 20231231-remote-fileio-24fbff0ba416
>
> Best regards,
> --
> Tom Tromey <tom@tromey.com>
>