From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WG0mKKg7UmU7jgUAWB0awg (envelope-from ) for ; Mon, 13 Nov 2023 10:07:20 -0500 Received: by simark.ca (Postfix, from userid 112) id A2AA31E0C1; Mon, 13 Nov 2023 10:07:20 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 968D71E091 for ; Mon, 13 Nov 2023 10:07:18 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 559A63891B41 for ; Mon, 13 Nov 2023 15:07:18 +0000 (GMT) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by sourceware.org (Postfix) with ESMTPS id 40A9B388C55D for ; Mon, 13 Nov 2023 15:05:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40A9B388C55D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 40A9B388C55D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699887922; cv=none; b=npcNWCpEW0i6p4TLvQgKtCg9545cVZcGdNhbVkNWzExB/YX5MgNgplDmf7MDHCxchJS+dkkgjwPmAr1hrq/kAoQXbTKsSC7mvOe52pdZj1ngBQ1+p2f1PI2xLzGVl5AjCLM46pbhy3v4S+Y/n61r48gnAcYTyOnWGY19se26QjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699887922; c=relaxed/simple; bh=ydWYTE3oMxy7dnsCH8T3QB7l3NwaBDu6v01Rk6/oLxg=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=kcFWyxdQyRw00QGOYPpHy5KjYp7nzAfjzDKMCXM+438/U2T+e2O6pqXCT7Umdu1REh3kNPtwNgs49gfei6CGm5j6nUjTb1eHoy/esMTOjkF4HaKcC8FcNogRfXmF2hfzfbce+7xqrUMUFFcAlsYDfn1Opv45PMJrlqfeL5SR9DY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4083cd3917eso37034345e9.3 for ; Mon, 13 Nov 2023 07:05:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699887920; x=1700492720; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+ykMbwy2/nH9QQ496bN15/gc2gL+FvAWd/Z6mQm1NTI=; b=vJxl3/52A6FS8YRW2mfUgJpyXxKkjIs3JVlRUUWfeymKB+8WzP/4gvRmYVOqf7gvjM rE0eUioi0+7q6OfZwha9Le2ea1u0rsq9kcqcqEjl/iPB2aciMI5HZXv/Djlue7VumXlK j5OjbQficcQa36dKZYuir4X2lnGsQOlvFJeViOcJ1YQjSOrWRZ/OjnM57xuaAB9fI1t8 NrZwsENTJNe8cshgRwQGGpudC8U229AKHPcyizR26VC3sxQlcaXO5VkFp53t0cw4S153 ovAKUxUCuIidbzefrVoVfeLF1YC+xxDBnNAr/KwqehoNChSPqV+Yi3PHpvl3ktshxviB +kzA== X-Gm-Message-State: AOJu0YyA+92o5YuMRLVO0WECxcl3H/3ObcxxvPfd3WeC+0dWJN08Gb7h nsdo9S0msrEY0+bEzz+HmdypOzlkDY0= X-Google-Smtp-Source: AGHT+IGkSixR6wYunpzvqjxBGkin2YMcx2TZNULYbgPQCas3Afb0wxjDldp1Ke+2HzxLSmUYEnY6Qw== X-Received: by 2002:a05:600c:1c9a:b0:407:8317:ad81 with SMTP id k26-20020a05600c1c9a00b004078317ad81mr5517041wms.1.1699887919721; Mon, 13 Nov 2023 07:05:19 -0800 (PST) Received: from localhost ([2001:8a0:f91e:1a00:8060:1e54:fb28:9635]) by smtp.gmail.com with UTF8SMTPSA id m15-20020a05600c4f4f00b004083bc9ac90sm8337388wmq.24.2023.11.13.07.05.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 07:05:19 -0800 (PST) From: Pedro Alves To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [FYI/pushed v4 10/25] Remove gdb/19675 kfails (displaced stepping + clone) Date: Mon, 13 Nov 2023 15:04:12 +0000 Message-Id: <20231113150427.477431-11-pedro@palves.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231113150427.477431-1-pedro@palves.net> References: <20231113150427.477431-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Now that gdb/19675 is fixed for both native and gdbserver GNU/Linux, remove the gdb/19675 kfails. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=19675 Reviewed-By: Andrew Burgess Change-Id: I95c1c38ca370100675d303cd3c8995860bef465d --- gdb/testsuite/gdb.base/step-over-syscall.exp | 44 ++------------------ 1 file changed, 3 insertions(+), 41 deletions(-) diff --git a/gdb/testsuite/gdb.base/step-over-syscall.exp b/gdb/testsuite/gdb.base/step-over-syscall.exp index 1f1e62296c6..a03ed2d455c 100644 --- a/gdb/testsuite/gdb.base/step-over-syscall.exp +++ b/gdb/testsuite/gdb.base/step-over-syscall.exp @@ -42,46 +42,17 @@ if { [istarget "i\[34567\]86-*-linux*"] || [istarget "x86_64-*-linux*"] } { } proc_with_prefix check_pc_after_cross_syscall { displaced syscall syscall_insn_next_addr } { - global gdb_prompt - set syscall_insn_next_addr_found [get_hexadecimal_valueof "\$pc" "0"] # After the 'stepi' we expect thread 1 to still be selected. - # However, when displaced stepping over a clone bug gdb/19675 - # means this might not be the case. - # - # Which thread we end up in depends on a race between the original - # thread-1, and the new thread (created by the clone), so we can't - # guarantee which thread we will be in at this point. - # - # For the fork/vfork syscalls, which are correctly handled by - # displaced stepping we will always be in thread-1 or the original - # process at this point. set curr_thread "unknown" - gdb_test_multiple "info threads" "" { - -re "Id\\s+Target Id\\s+Frame\\s*\r\n" { - exp_continue - } - -re "^\\* (\\d+)\\s+\[^\r\n\]+\r\n" { + gdb_test_multiple "thread" "" { + -re -wrap "Current thread is (\\d+) .*" { set curr_thread $expect_out(1,string) - exp_continue - } - -re "^\\s+\\d+\\s+\[^\r\n\]+\r\n" { - exp_continue - } - -re "$gdb_prompt " { + pass $gdb_test_name } } - # If we are displaced stepping over a clone, and we ended up in - # the wrong thread then the following check of the $pc value will - # fail. - if { $displaced == "on" && $syscall == "clone" && $curr_thread != 1 } { - # GDB doesn't support stepping over clone syscall with - # displaced stepping. - setup_kfail "*-*-*" "gdb/19675" - } - gdb_assert {$syscall_insn_next_addr != 0 \ && $syscall_insn_next_addr == $syscall_insn_next_addr_found \ && $curr_thread == 1} \ @@ -299,15 +270,6 @@ proc step_over_syscall { syscall } { gdb_test "break marker" "Breakpoint.*at.* file .*${testfile}.c, line.*" - # If we are displaced stepping over a clone syscall then - # we expect the following check to fail. See also the - # code in check_pc_after_cross_syscall. - if { $displaced == "on" && $syscall == "clone" } { - # GDB doesn't support stepping over clone syscall with - # displaced stepping. - setup_kfail "*-*-*" "gdb/19675" - } - gdb_test "continue" "Continuing\\..*Breakpoint \[0-9\]+, marker \\(\\) at.*" \ "continue to marker ($syscall)" } -- 2.34.1