From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YHNjGcdzPWUsUzkAWB0awg (envelope-from ) for ; Sat, 28 Oct 2023 16:49:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=oh8JZaom; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 643771E0C1; Sat, 28 Oct 2023 16:49:11 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C27691E00F for ; Sat, 28 Oct 2023 16:49:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D8FA1386185E for ; Sat, 28 Oct 2023 20:49:07 +0000 (GMT) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2056.outbound.protection.outlook.com [40.107.96.56]) by sourceware.org (Postfix) with ESMTPS id 177813857C66 for ; Sat, 28 Oct 2023 20:48:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 177813857C66 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 177813857C66 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.96.56 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698526135; cv=pass; b=iKXdhWUqNL10WALnU8nrVdDRDU1nHTjgGvNzMNfftQMiuBxzKNqa/0BxRFiqXP0/eRTL8vZTJaYx70lVYpP5Oc1FpsoLjMwclPN0RoLHQ9x19UcKOurboqQuCl9Jd3qjsXP/cIyQ4NizcIh8cLG/L49EtKBECRCtUOd6ccWeUI0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698526135; c=relaxed/simple; bh=d0x2MUfxvZ2mGwpPblKFYTDA0XMj6z2xqXNdyJMsHos=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=LowpNa1R7Db+DSFB0mOxHB10fkQOlxOKDce0RUT3UwAW1WhoFuiEerodYbsfUjIaysMyYxRyDB8FjpD5x9uk2SdHVLvw5dOQ/AA5Img93UjKuD9pEwD9iwbbqJBrwM1mIsR03s2dF5eqEBwh0QLs08zBKu+992GRPBO+MmKYIig= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjR9V1BEVPPF4z354Iuq2heSLK4xeYl9NQ7Yu+TfUYVh43Zy8nGO7ioRUf0Qo3LyHvVdunZzpK9Zj2XsFT0rYKG+Frl5bD5fKA0eFKLcdXUYYMHteBwUaRFeDvAK3PuVTuipfOo9+J88D72dPpFrfKvAXGRvh2T55BEiXMEFu0Ynbksl6+BPGnnxKC/7Ua4KIgbbsUTJPVua+XB6j21gg2URex/Bhz+9l4CIrtWLpz9E9Wh8N5B5T9OTfEXVOkEfuZN9XA0AH+8WCVgy2jDPl5k1JIq9fHFdDalXMPYfKRXcmrH38jRXkxx2R4uqXAqe4vCeVJzUQU5Hv6zTOATSpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K4jKfSxnTDLRA+Rt52EdSptyUs6/hbSsQO/QWdSkGFA=; b=NHw3SKiJwVXu9GjMQPLbjHDo7EwWCaFr16p34OnLZ01Ny3XPS8fuJOzt61iTAaoRvZ4KCoRN8sIf823YEHY4LmtXcaAL0vKfMyrbOT17pd6JRIWICK3w3NK1ifBSEivg5Rs1uWwkuT2SK2BuQUJG8mRM+BguyXk+XaNU+GMGyIqv30N+8YCdKP6NCSBXZmgzB2A3DpP+F3ZkYYouoojF/yuqxS+geZDmMKzo0ERQW72hpB3vDxE7tlvgoAniue+3GzFxcZOw6aL2S+OSO5W7XH2P9b2AP2fZibBevE+TG5b6U9ZvDMJWuYI5R0OJHR784wc4lHRMOVxgppGfJ0sbsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=palves.net smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K4jKfSxnTDLRA+Rt52EdSptyUs6/hbSsQO/QWdSkGFA=; b=oh8JZaomExkcFMK/riDJS4p7NPmOPUrsPEo2wOH/2FoK8q8an5jVzJtb3Hr792KaQMI2rRX1JDS9tlJFoczjLMSaEn8U2COnL8tD8g8lNcXK8QYTvomDxmGtM/LQuyedHeEzxwnN3YfD/EMM+HR7yvRzjDzLVjEJqtb7uKoGPLI= Received: from PH8PR05CA0014.namprd05.prod.outlook.com (2603:10b6:510:2cc::7) by DM6PR12MB4420.namprd12.prod.outlook.com (2603:10b6:5:2a7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.23; Sat, 28 Oct 2023 20:48:48 +0000 Received: from SN1PEPF0002BA4B.namprd03.prod.outlook.com (2603:10b6:510:2cc:cafe::d9) by PH8PR05CA0014.outlook.office365.com (2603:10b6:510:2cc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.11 via Frontend Transport; Sat, 28 Oct 2023 20:48:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002BA4B.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6933.15 via Frontend Transport; Sat, 28 Oct 2023 20:48:47 +0000 Received: from hpe6u-23 (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sat, 28 Oct 2023 15:48:46 -0500 Date: Sat, 28 Oct 2023 20:48:40 +0000 From: Lancelot SIX To: Pedro Alves , Tom Tromey CC: Subject: Re: [PATCH 00/11] GDB: Require C++17 Message-ID: <20231028204821.fp5hh7bahrmrnpjl@hpe6u-23> References: <20231013144418.3180617-1-lancelot.six@amd.com> <87o7gyqros.fsf@tromey.com> <95cba198-ad2c-4959-8d46-ef87d1492b91@palves.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4B:EE_|DM6PR12MB4420:EE_ X-MS-Office365-Filtering-Correlation-Id: 0cdc1341-75f6-46bb-b70b-08dbd7f7488d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZjlO3tieaACSTbU+/zAi8Wq6EI6dGukW6AhxWoZsiXUcDEyNRej3wJJdw7Llzv6e1kbKtdvFp7NN6zhVUKlMz1r9EQoRHdPNb7Oyi1U42uzZoRC5W9VUtWWqExqPptnHZ3kNsfylFKetSIKZ7shcRlOtVB5Nzja/us4nTrjYXddk2M+xEZzZauZmjfqN385wBTTRkpfqQc6nAaQDQnhl1HiWP7U5QygKs5/GHXvSwjgTXdMpiofMmzXuK9o+pIZOOR2nUQFMlWpPHokz71l8L3wNvCujRMMbYL+Xx25zBvGv+NqFbe6x3y9Dbj0dMaANmXMMoa5s9vJ6MxJwim1EfAGDCSQgpq7Fz1FnpEsUh5xvNskDiHb0mgEZTEnDEi11G1VV4Y8yHKRFOCMDnSvBhTxZ9jzj7DdF3Q0d/o+G7xXjAxuktzF7uECHXlsAgPycab2cfblgQ8TjB5aOWeCwmJeSEv9MNmHuY24j/KpApTxgiqvYm4dAYetA9SSWHXjlPOKWVQCU+rEkq2aUK0iTHSSN6ndYBE9Tj5v0DBzInXLPrwlsEdPugvy+Qq94O1bG/pH47y+fDCByW2N3d4jvX18g9/yHxAPeT6y1mDulpc0MkE1sKfAMn7BJu+m9f+Bt2cldb8VS3pyi67qqLqYWj1LA+hHbiQ4A0YO1VRaetoWiVWfq6A9uEs0tHrYpGvQAGrKzbABrtevGqoap0zFAIHf79OU2jOdHQPn9J/sp6pWzvwsa0K6ApA3XaJYqA1+QkPYzEvR7GFSqwpKuW5TBWA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(346002)(39860400002)(136003)(396003)(230922051799003)(82310400011)(1800799009)(451199024)(186009)(64100799003)(46966006)(40470700004)(36840700001)(36860700001)(81166007)(356005)(26005)(16526019)(47076005)(55016003)(40460700003)(83380400001)(4326008)(70206006)(41300700001)(8936002)(8676002)(2906002)(70586007)(110136005)(5660300002)(86362001)(316002)(426003)(478600001)(336012)(6666004)(82740400003)(33716001)(40480700001)(9686003)(1076003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2023 20:48:47.6573 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0cdc1341-75f6-46bb-b70b-08dbd7f7488d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4B.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4420 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Mon, Oct 23, 2023 at 02:42:18PM +0100, Lancelot SIX wrote: > > > > Lancelot> This series is a followup of the discussions from last Cauldron and Tom's > > > Lancelot> RFC patch[1] regarding requiring C++17 in GDB. It seems that the > > > Lancelot> overall sentiment is positive for such move, so here is a proper series. > > > > > > Hi. I've sent a few minor comments, but otherwise everything looks good > > > to me. > > > > > > Thank you for doing this. > > > > Ditto. > > > > > > > > Approved-By: Tom Tromey > > > > > > I'm giving my approval but this should probably wait a little for others > > > to comment as well. > > > > and ditto here too. You can add mine: > > > > Approved-By: Pedro Alves > > > > Hi all, > > I think I'll wait until about the end of the week and will push the first 2 > patches of the series. This will make master require C++17 but not actually > use C++17 yet. I'll give a bit more time for the rest of the series, so if > it causes problems to anyone, it is still easy to revert. > > Best, > Lancelot. Hi all, I have pushed the first 2 patches of the series (including the missing update in gdb/README): - eb4de4047d8 gdb/ax_cxx_compile_stdcxx.m4: upgrade - f74dc26792a gdb/gdbsupport/gdbserver: Require c++17 I'll wait a bit more before applying the rest of the series. The intent is to have a time-window where C++17 is required but not extensively used so it is still "easy" to revert the change is someone strongly objects to it. I think I'll wait at least a week or two before considering pushing the rest of the series. Best, Lancelot.