Re: [PATCH 16/24] gdb: make clear_so a method of struct so_list

Simon Marchi
2023-10-19T14:52:46Z

On 10/19/23 07:08, Lancelot SIX wrote:
> Hi Simon,
>
> On Tue, Oct 10, 2023 at 04:40:11PM -0400, Simon Marchi wrote:
>> ... just because it seems to make sense to do so.
>>
>> Change-Id: Ie283c92d9b90c54e3deee96a43c6a942d8b5910b
>> ---
>> gdb/solib.c | 35 ++++++++++++++---------------------
>> gdb/solist.h | 10 ++++++++++
>> 2 files changed, 24 insertions(+), 21 deletions(-)
>>
>> diff --git a/gdb/solib.c b/gdb/solib.c
>> index 5ed223b8dfca..8f5b6e02e71c 100644
>> --- a/gdb/solib.c
>> +++ b/gdb/solib.c
>> @@ -623,39 +623,32 @@ solib_map_sections (so_list &so)
>> return 1;
>> }
>>
>> -/* Free symbol-file related contents of SO and reset for possible reloading
>> - of SO. If we have opened a BFD for SO, close it. If we have placed SO's
>> - sections in some target's section table, the caller is responsible for
>> - removing them.
>> +/* See solist.h. */
>>
>> - This function doesn't mess with objfiles at all. If there is an
>> - objfile associated with SO that needs to be removed, the caller is
>> - responsible for taking care of that. */
>> -
>> -static void
>> -clear_so (so_list &so)
>> +void
>> +so_list::clear ()
>> {
>> const target_so_ops *ops = gdbarch_so_ops (current_inferior ()->arch ());
>>
>> - delete so.sections;
>> - so.sections = NULL;
>> + delete this->sections;
>> + this->sections = NULL;
>
> That's just a nit, but while at touching those lines, the NULL could be
> changed to nullptr.

Done.

Simon