Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Lancelot Six <lancelot.six@amd.com>
To: <gdb-patches@sourceware.org>
Cc: Lancelot Six <lancelot.six@amd.com>
Subject: [PATCH v2] gdb/testsuite/gdb.rocm: Fix incorrect use of continue N in multi-inferior-gpu.exp
Date: Wed, 18 Oct 2023 10:24:53 +0000	[thread overview]
Message-ID: <20231018102453.355287-1-lancelot.six@amd.com> (raw)
In-Reply-To: <20231017111629.307261-1-lancelot.six@amd.com>

The gdb.rocm/multi-inferior-gpu.exp testcase uses a "continue $thread"
command, but this is incorrect.  If "continue" is given an argument, it
sets the ignore count of the breakpoint the thread stopped at.

For this testcase it does not really matter since the breakpoint is not
meant to be hit anymore, so whatever the ignore count is won't influence
the outcome of the test.  It is worth fixing nevertheless.

Change-Id: I0eb674d5529cdeb9e808b74870a29b6077265737
---
Changes since V1:
- Following Simon's comments, remove the "continue" -> "continue&"
  change.  Even if this test is in non-stop mode, this change should not
  be required to esure when the GDB prompt is seen.

Best,
Lancelot.

---
 gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
index 18b4172ff09..5bac50d2ef8 100644
--- a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
+++ b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
@@ -68,7 +68,7 @@ proc do_test {} {
 	foreach thread $stopped_gpu_threads {
 	    set infnumber [lindex [split $thread .] 0]
 	    gdb_test "thread $thread" "Switching to thread.*"
-	    gdb_test_multiple "continue $thread" "" {
+	    gdb_test_multiple "continue" "continue inferior $infnumber" {
 		-re "\\\[Inferior $infnumber \[^\n\r\]* exited normally\\]\r\n$::gdb_prompt " {
 		    pass $gdb_test_name
 		}

base-commit: fded0fb898618b5b659762ace776144afa876035
-- 
2.34.1


  parent reply	other threads:[~2023-10-18 10:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 11:16 [PATCH] " Lancelot Six
2023-10-17 11:21 ` Lancelot SIX
2023-10-17 14:25 ` Simon Marchi
2023-10-17 14:41   ` Lancelot SIX
2023-10-17 14:48     ` Simon Marchi
2023-10-18  8:32       ` Lancelot SIX
2023-10-18 10:24 ` Lancelot Six [this message]
2023-10-18 20:26   ` [PATCH v2] " Simon Marchi
2023-10-18 20:32     ` Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018102453.355287-1-lancelot.six@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox