Re: [PATCH v2] gdb/testsuite/gdb.rocm: Fix incorrect use of continue N in multi-inferior-gpu.exp

Simon Marchi
2023-10-18T20:26:56Z

On 10/18/23 06:24, Lancelot Six wrote:
> The gdb.rocm/multi-inferior-gpu.exp testcase uses a "continue $thread"
> command, but this is incorrect. If "continue" is given an argument, it
> sets the ignore count of the breakpoint the thread stopped at.
>
> For this testcase it does not really matter since the breakpoint is not
> meant to be hit anymore, so whatever the ignore count is won't influence
> the outcome of the test. It is worth fixing nevertheless.
>
> Change-Id: I0eb674d5529cdeb9e808b74870a29b6077265737
> ---
> Changes since V1:
> - Following Simon's comments, remove the "continue" -> "continue&"
> change. Even if this test is in non-stop mode, this change should not
> be required to esure when the GDB prompt is seen.
>
> Best,
> Lancelot.
>
> ---
> gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
> index 18b4172ff09..5bac50d2ef8 100644
> --- a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
> +++ b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
> @@ -68,7 +68,7 @@ proc do_test {} {
> foreach thread $stopped_gpu_threads {
> set infnumber [lindex [split $thread .] 0]
> gdb_test "thread $thread" "Switching to thread.*"
> - gdb_test_multiple "continue $thread" "" {
> + gdb_test_multiple "continue" "continue inferior $infnumber" {
> -re "\\\[Inferior $infnumber \[^\n\r\]* exited normally\\]\r\n$::gdb_prompt " {
> pass $gdb_test_name
> }
>
> base-commit: fded0fb898618b5b659762ace776144afa876035
> --
> 2.34.1
>

Thanks, LGTM:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon