From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KOd5Fx0PLWXwPy8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 06:23:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=lancelotsix.com header.i=@lancelotsix.com header.a=rsa-sha256 header.s=2021 header.b=0hsOJ8o1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5C7041E0C1; Mon, 16 Oct 2023 06:23:25 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4648A1E00F for ; Mon, 16 Oct 2023 06:23:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ABBA53858C33 for ; Mon, 16 Oct 2023 10:23:22 +0000 (GMT) Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id DF2613858D33 for ; Mon, 16 Oct 2023 10:23:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF2613858D33 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DF2613858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=51.195.220.111 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697451793; cv=none; b=lCcG0/ZLSS/x5qd6KQKqq/5pFDAhI89lRtD2DjFn+7X5TalaokTUS5JXk2iFpdshj5LLhKSpo8m+VALRGcxq2FGi1VYm+e74hi+fM9AeudwiCX0R+Ko9Zvf/fAnBxg6RlXs4DHfPgZe0lCRrUXX5pxgDVaQx2ueKVMC7vn1jpSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697451793; c=relaxed/simple; bh=oFQQ9wARo+mRHTY3pJAQaX13drlbjrx9iOqu1gIYCu8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=b4V9HeDSBuXgnYRpvq47D7lZttvWHozneUaMdnt5hxjnK+RhzUh3DDXC1nIQF3VIzJr3U9K+UjXTjI/5YSgEomCL+4+nq1RGAPEe+UNa2AI9k+2RoS143lv3675Xa7FCqPVrm3Ie2mR8EPYpSR1pZ1aaNRH4J4Y943Nwdef4xZQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 1130984CB8; Mon, 16 Oct 2023 10:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com; s=2021; t=1697451791; bh=oFQQ9wARo+mRHTY3pJAQaX13drlbjrx9iOqu1gIYCu8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0hsOJ8o1Y73IM77z+TSbAOHSUqk+PaoJ65It21jk2EV4wiUsmvI5UFpCoeyQLDZpD kNjzSTotx/qVt46tSC+fvxSMfz1eWW/9eDb1PqauGnqiNeczv3jxZzqKETcbABlcoG K0Za3SwD+uvlTqHT2sgKp1bemCnB66YxHztiBeCdiFsdQo+CeNGkmDEDBnvcStmWl7 hUQ/jrtPxGpb6cmbwfkNF0zJ3fJaCpGwEMCInJrM6TAAzVu8sy0qWD7jg86n9Ep2RK BCLEVhjC65JrIBMu8GrImUmEGT7HX3O17JLfoi/Ta6wP0/kJYkgDkf7UHwBJyuHBtH 6ZX2/2YP9wtpA== Date: Mon, 16 Oct 2023 11:23:06 +0100 From: Lancelot SIX To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 0/4] [gdb/cli] Allow source highlighting to be interrupted Message-ID: <20231016102306.e5fd3accy3br2aqd@octopus> References: <20231016091748.26247-1-tdevries@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231016091748.26247-1-tdevries@suse.de> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Mon, 16 Oct 2023 10:23:11 +0000 (UTC) X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi, I went through the series, and except for one minor formatting detail in the last patch, it LGTM. Reviewed-By: Lancelot Six Best, Lancelot. On Mon, Oct 16, 2023 at 11:17:44AM +0200, Tom de Vries wrote: > I wrote this patch series to fix PR cli/30934. > > The 1st patch is an unrelated optimization, which I added to this series > because it touches the same code. > > The 2nd patch factors out a function. > > The 3rd patch adds a means to keep track of styling failures in the > source cache, as suggested here ( > https://sourceware.org/pipermail/gdb-patches/2023-October/203164.html ). > > The 4th patch fixes the PR cli/30934. > > Changes in v3: > - dropped the "#if __cplusplus >= 202002L" in the first patch. > - added a reset of the highlighter's EventListener to prevent a dangling > pointer. > > Changes in v2: > - fixed a build problem with --disable-source-highlight, reported by the linaro > CI. > - temporarily installs the default_quit_handler to be able to use QUIT > - added a question whether to interrupt highlighting or not > (in the RFC, I had a warning, in v1 I dropped it) > - added "gdb_assert (target_terminal::is_ours ())" > > Adding the question was inspired by the v3 patch "gdb/debuginfod: Ctrl-C ask > to cancel further downloads" ( > https://sourceware.org/pipermail/gdb-patches/2023-March/197679.html ). > > Submission history: > - RFC: > https://sourceware.org/pipermail/gdb-patches/2023-October/203157.html > - v1: > https://sourceware.org/pipermail/gdb-patches/2023-October/203179.html > - v2: > https://sourceware.org/pipermail/gdb-patches/2023-October/203199.html > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30934 > > Tom de Vries (4): > [gdb/cli] Skip string copy in source_cache::ensure > [gdb/cli] Factor out try_source_highlight > [gdb/cli] Keep track of styling failures in source_cache > [gdb/cli] Allow source highlighting to be interrupted > > gdb/source-cache.c | 175 +++++++++++++++++++++++++++++++++++---------- > gdb/source-cache.h | 4 ++ > 2 files changed, 143 insertions(+), 36 deletions(-) > > > base-commit: 6674b23fe6409e08de9c36f640bd58127eff9dda > -- > 2.35.3 >