From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UWmpN6bzLGVzLC8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 04:26:14 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=lancelotsix.com header.i=@lancelotsix.com header.a=rsa-sha256 header.s=2021 header.b=Fbp6FJuW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D93B91E0C1; Mon, 16 Oct 2023 04:26:14 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 53C331E00F for ; Mon, 16 Oct 2023 04:26:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 93CAA3856DF1 for ; Mon, 16 Oct 2023 08:26:11 +0000 (GMT) Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 767393858402 for ; Mon, 16 Oct 2023 08:25:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 767393858402 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 767393858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=51.195.220.111 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697444761; cv=none; b=tU1fp4sFQ6Bq8Az6NFtifKVZBPHRT27vgTAJ/py1Twx+69OGdn2TaEjWWZDur/6PGakNfvDanfMmqpFRHls+4DfOcd1SGeZsrCRiZ17akmPECygvNXQEE/uvce81x0I/xO3xWXfrnjxbb6994Gc08vzhwVw77n7mo9QUsvJYyQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697444761; c=relaxed/simple; bh=vpKIQ8l6UbN5X6P60jT9xnKVNUxjOEQZ+YeficXBAlw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=xtvQzG3HiumriZCx5Ta3e55jtD9Y2jGO/by9xTHpoZ0/Ke8lmmr2Px+i49jbPuSll4Agu8o4LJ/nHuPS+WEEzwxeGIT+VHD0I4BiGZc81KYDotlu/0DBgtQJh1F8Q27AYqjRV20XdQIjZkocEEI5m8tk10IXLr9aksmDNTD1yDk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 1604384CB8; Mon, 16 Oct 2023 08:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com; s=2021; t=1697444752; bh=vpKIQ8l6UbN5X6P60jT9xnKVNUxjOEQZ+YeficXBAlw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fbp6FJuWjcKt/xo/T2nXtDFQOnBdD8hYE2CtNWZYdJvpIw9+Cfkf5FomQtzRVL+Vl 2xeIIbBQ0p+5J04qIXIsjVQa9eXYzEghNmHA1R+l9F/sRCdf2kcCcxRYePo0FGvuxe mbZkzF1MCQ5jqgrNmTNZDita7PKpgcYJG9DZdGxZjVqpZ22XlEmmRJHf/xVbSxg4rF KuJcnQrC3CM9EFVSz/xSaG3rtlNvZNf4xTPs1LYTt2v3ObUysWhBMTW8mRX0ZG4nU7 4pmlqihW8QU/zt/9zQBjjkkwnfaUsCNwllU4UOIqbIYw0ONGH2DR4MvjGBoH/z/sZ7 a7RiIcbZPzQTA== Date: Mon, 16 Oct 2023 09:25:45 +0100 From: Lancelot SIX To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/4] [gdb/cli] Factor out try_source_highlight Message-ID: <20231016082545.pd2nms4opokdl3rr@octopus> References: <20231013121953.25917-1-tdevries@suse.de> <20231013121953.25917-3-tdevries@suse.de> <20231013165223.ahgvhgfbcod2fsz6@octopus> <524b62b4-bf07-4ed5-b8a2-2ad8dac11043@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <524b62b4-bf07-4ed5-b8a2-2ad8dac11043@suse.de> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Mon, 16 Oct 2023 08:25:52 +0000 (UTC) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > > Hi, > > The pre-existing code is a result of commit f64e2f40454 ("[gdb] Catch > exception when constructing the highlighter"), which does the opposite of > what you propose here. > > And I think the rationale given there still holds. > Hi Tom, Thanks for pointing this out, I missed this commit. Best, Lancelot. > I suppose if we're interested in not hiding that new throws, you could catch > the exceptions of interest and handle them appropriately, by say issuing a > warning or rethrowing. > > I will leave this as is for now. > > Thanks, > - Tom >