Re: [PATCH v2 2/4] [gdb/cli] Factor out try_source_highlight

Lancelot SIX
2023-10-16T08:26:14Z

>
> Hi,
>
> The pre-existing code is a result of commit f64e2f40454 ("[gdb] Catch
> exception when constructing the highlighter"), which does the opposite of
> what you propose here.
>
> And I think the rationale given there still holds.
>

Hi Tom,

Thanks for pointing this out, I missed this commit.

Best,
Lancelot.

> I suppose if we're interested in not hiding that new throws, you could catch
> the exceptions of interest and handle them appropriately, by say issuing a
> warning or rethrowing.
>
> I will leave this as is for now.
>
> Thanks,
> - Tom
>