From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gWAIIcDgFGX66B4AWB0awg (envelope-from ) for ; Wed, 27 Sep 2023 22:11:12 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=INNTmJne; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7A2321E0C3; Wed, 27 Sep 2023 22:11:12 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 68AAA1E028 for ; Wed, 27 Sep 2023 22:11:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C11943858402 for ; Thu, 28 Sep 2023 02:11:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C11943858402 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695867069; bh=pAo05H8p3fQautH2+2v7+dBfDIFZIgdTmfuwz2jwiLY=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=INNTmJne2MY3nk0tcQ1uMN9sxOcNRbxPpKoQH5FG9EPHFb6fCEclj5xu+LWM4TPiA OzaM+VlsOMbZB0QOxZLh9XDxdM6ouvx7jxfbhmhh7d2s7rX861WPK+9+rt6UQe2E6W fbme8+zQjmb2b0UIFkXF8qQ3darmvix65vkj6WSI= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id ECE823858C00 for ; Thu, 28 Sep 2023 02:10:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECE823858C00 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-NUu5DHkrNvOuzCy__By2Mw-1; Wed, 27 Sep 2023 22:10:47 -0400 X-MC-Unique: NUu5DHkrNvOuzCy__By2Mw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E74208039D1; Thu, 28 Sep 2023 02:10:46 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.32.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4515C15BB8; Thu, 28 Sep 2023 02:10:46 +0000 (UTC) Date: Wed, 27 Sep 2023 19:10:45 -0700 To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH] [gdb/testsuite] Add nopie to gdb.base/unwind-on-each-insn-amd64-2.exp Message-ID: <20230927191045.61290109@f37-zws-nv> In-Reply-To: <20230927072410.7000-1-tdevries@suse.de> References: <20230927072410.7000-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Wed, 27 Sep 2023 09:24:10 +0200 Tom de Vries via Gdb-patches wrote: > When running test-case gdb.base/unwind-on-each-insn-amd64-2.exp with target > board unix/-fPIE/-pie, I run into: > ... > gdb compile failed, ld: unwind-on-each-insn-amd64-21.o: relocation \ > R_X86_64_32S against `.text' can not be used when making a PIE object; \ > recompile with -fPIE > ld: failed to set dynamic section sizes: bad value > ... > > Fix this by hardcoding nopie in the test-case, and for good measure in the > other test-cases that source unwind-on-each-insn.exp.tcl and use a .s file. Looks reasonable to me. Approved-by: Kevin Buettner