From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3r9+GxeeFGWpvh4AWB0awg (envelope-from ) for ; Wed, 27 Sep 2023 17:26:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=iQHtqfir; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 631FE1E0C3; Wed, 27 Sep 2023 17:26:47 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4FD6D1E092 for ; Wed, 27 Sep 2023 17:26:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D71B38618DB for ; Wed, 27 Sep 2023 21:26:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D71B38618DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695850004; bh=rXNRnMgtAn/oL8QS5ro0ldUqWyGZjwvia2CG+GK9fnc=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=iQHtqfirjkOdOpa7MB8TN18iq0aRhPLkw8vDTkCul0ZpETghgq8soYKIsrI/HGVUB TWX14PVOmqFUnE/6alyModpCDC2AS6qpIoiw22tk7HkpqnCNUywKy/sO7vJqgMiFrO 5vpWBlFw1/DyZ3tuGxG/SE9SAPOfp6Clu+dRhlWY= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 673B5385828D for ; Wed, 27 Sep 2023 21:26:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 673B5385828D Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-532-bzuGDyHCMkSvpXa-x-l-GQ-1; Wed, 27 Sep 2023 17:26:22 -0400 X-MC-Unique: bzuGDyHCMkSvpXa-x-l-GQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 77E453800C46 for ; Wed, 27 Sep 2023 21:26:21 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.32.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20C63400E89; Wed, 27 Sep 2023 21:26:20 +0000 (UTC) Date: Wed, 27 Sep 2023 14:26:19 -0700 To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 1/2] gdb/record: print frame information when exiting a recursive call Message-ID: <20230927142619.04ca311d@f37-zws-nv> In-Reply-To: <20230927101950.1913970-4-blarsen@redhat.com> References: <20230927101950.1913970-3-blarsen@redhat.com> <20230927101950.1913970-4-blarsen@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Gwen, On Wed, 27 Sep 2023 12:19:51 +0200 Guinevere Larsen wrote: > gdb/infrun.c | 18 ++++++++++ > gdb/testsuite/gdb.reverse/recursion.c | 44 ++++++++++++++++++++++++ > gdb/testsuite/gdb.reverse/recursion.exp | 45 +++++++++++++++++++++++++ > 3 files changed, 107 insertions(+) > create mode 100644 gdb/testsuite/gdb.reverse/recursion.c > create mode 100644 gdb/testsuite/gdb.reverse/recursion.exp I've applied your patch and have tested on Fedora 38, for both x86_64 and aarch64 (both native). I see no regressions on aarch64, but on x86_64, I'm seeing this failure when your patch is applied: FAIL: gdb.dwarf2/dw2-out-of-range-end-of-seq.exp: END with address 1 eliminated After studying the log files, this makes absolutely no sense to me since your patch should not have any affect on the "maint info line-table" command. Here are the relevant sections of the log files: - - - passing run - - - (gdb) break -qualified main Breakpoint 1 at 0x40110a: file /ironwood1/sourceware-git/f38-review/bld/../../worktree-review/gdb/testsuite/gdb.dwarf2/main.c, line 1. (gdb) run Starting program: /mesquite2/sourceware-git/f38-review/bld/gdb/testsuite/outputs/gdb.dwarf2/dw2-out-of-range-end-of-seq/dw2-out-of-range-end-of-seq [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Breakpoint 1, 0x000000000040110a in main () at /ironwood1/sourceware-git/f38-review/bld/../../worktree-review/gdb/testsuite/gdb.dwarf2/main.c:1 1 /* This testcase is part of GDB, the GNU debugger. (gdb) maint info line-table main.c$ objfile: /mesquite2/sourceware-git/f38-review/bld/gdb/testsuite/outputs/gdb.dwarf2/dw2-out-of-range-end-of-seq/dw2-out-of-range-end-of-seq ((struct objfile *) 0x18e5670) compunit_symtab: main.c ((struct compunit_symtab *) 0x18e5b90) symtab: /mesquite2/sourceware-git/worktree-review/gdb/testsuite/gdb.dwarf2/main.c ((struct symtab *) 0x18e5c10) linetable: ((struct linetable *) 0x18e5e30): INDEX LINE REL-ADDRESS UNREL-ADDRESS IS-STMT PROLOGUE-END 0 1 0x0000000000401106 0x0000000000401106 Y 1 END 0x0000000000401111 0x0000000000401111 Y (gdb) PASS: gdb.dwarf2/dw2-out-of-range-end-of-seq.exp: END with address 1 eliminated testcase /ironwood1/sourceware-git/f38-review/bld/../../worktree-review/gdb/testsuite/gdb.dwarf2/dw2-out-of-range-end-of-seq.exp completed in 1 seconds - - - end passing run - - - - - - failing run - - - (gdb) break -qualified main Breakpoint 1 at 0x40110a: file /ironwood1/sourceware-git/f38-review/bld/../../worktree-review/gdb/testsuite/gdb.dwarf2/main.c, line 1. (gdb) run Starting program: /mesquite2/sourceware-git/f38-review/bld/gdb/testsuite/outputs/gdb.dwarf2/dw2-out-of-range-end-of-seq/dw2-out-of-range-end-of-seq [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Breakpoint 1, 0x000000000040110a in main () at /ironwood1/sourceware-git/f38-review/bld/../../worktree-review/gdb/testsuite/gdb.dwarf2/main.c:1 1 /* This testcase is part of GDB, the GNU debugger. (gdb) maint info line-table main.c$ objfile: /mesquite2/sourceware-git/f38-review/bld/gdb/testsuite/outputs/gdb.dwarf2/dw2-out-of-range-end-of-seq/dw2-out-of-range-end-of-seq ((struct objfile *) 0x24a85b0) compunit_symtab: main.c ((struct compunit_symtab *) 0x24a8ad0) symtab: /mesquite2/sourceware-git/worktree-review/gdb/testsuite/gdb.dwarf2/main.c ((struct symtab *) 0x24a8b50) linetable: ((struct linetable *) 0x24a8d70): INDEX LINE REL-ADDRESS UNREL-ADDRESS IS-STMT PROLOGUE-END 0 1 0x0000000000401106 0x0000000000401106 Y 1 END 0x0000000000401111 0x0000000000401111 Y objfile: /usr/lib/debug/usr/lib64/libc.so.6-2.37-4.fc38.x86_64.debug ((struct objfile *) 0x26435b0) compunit_symtab: ((struct compunit_symtab *) 0x2eb2260) symtab: /usr/src/debug/glibc-2.37-4.fc38.x86_64/intl/textdomain.c ((struct symtab *) 0x2f60430) linetable: ((struct linetable *) 0x0): No line table. objfile: /usr/lib/debug/usr/lib64/libc.so.6-2.37-4.fc38.x86_64.debug ((struct objfile *) 0x26435b0) compunit_symtab: ((struct compunit_symtab *) 0x2eb2260) symtab: /usr/src/debug/glibc-2.37-4.fc38.x86_64/support/support_test_main.c ((struct symtab *) 0x2f725d0) linetable: ((struct linetable *) 0x0): No line table. (gdb) FAIL: gdb.dwarf2/dw2-out-of-range-end-of-seq.exp: END with address 1 eliminated testcase /ironwood1/sourceware-git/f38-review/bld/../../worktree-review/gdb/testsuite/gdb.dwarf2/dw2-out-of-range-end-of-seq.exp completed in 1 seconds - - - end failing run - - - The difference here is that the failing run is (also) attempting to list the line table for libc (and twice for some reason). As noted earlier, I don't see how your change can affect this area of the code, but, multiple times, I've done a "git reset --hard" to get rid of your commit, followed by a rebuild and test, each time seeing the test pass. After that, I've applied your patch, rebuilt, and tested again, each time seeing this test fail. Are you able to reproduce this problem? (I'll continue to study it here - there may be something weird going on with the VM upon which I'm testing...) Kevin