From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GOM9H7DYE2UbLh4AWB0awg (envelope-from ) for ; Wed, 27 Sep 2023 03:24:32 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Yk28Q+4x; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 75D5A1E0C3; Wed, 27 Sep 2023 03:24:32 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 641AE1E028 for ; Wed, 27 Sep 2023 03:24:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA4333857726 for ; Wed, 27 Sep 2023 07:24:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA4333857726 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695799469; bh=epYBgRska9w0ncBMAzBDDOVSh3+f7h2NYCMaecZbDpM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Yk28Q+4xxgEUWye6k3IsHLnQ8WYNawzPaEWiNFiq5A2pDJJm3zUbr2Uwe1GJXwbpW oEaf+TF2HQ/7B84EGaFY29MldBO8167DsAr2GgzaJDKeXBv2Phi0apoVlcMMJEJVjp pzLMerEbbYzJysCPLqem6FW22ZVIaOIIEoNPxK6M= Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 593903858436 for ; Wed, 27 Sep 2023 07:24:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 593903858436 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 90BC11F892 for ; Wed, 27 Sep 2023 07:24:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7D2321338F for ; Wed, 27 Sep 2023 07:24:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NBB/HZnYE2X4QgAAMHmgww (envelope-from ) for ; Wed, 27 Sep 2023 07:24:09 +0000 To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/testsuite] Add nopie to gdb.base/unwind-on-each-insn-amd64-2.exp Date: Wed, 27 Sep 2023 09:24:10 +0200 Message-Id: <20230927072410.7000-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When running test-case gdb.base/unwind-on-each-insn-amd64-2.exp with target board unix/-fPIE/-pie, I run into: ... gdb compile failed, ld: unwind-on-each-insn-amd64-21.o: relocation \ R_X86_64_32S against `.text' can not be used when making a PIE object; \ recompile with -fPIE ld: failed to set dynamic section sizes: bad value ... Fix this by hardcoding nopie in the test-case, and for good measure in the other test-cases that source unwind-on-each-insn.exp.tcl and use a .s file. Tested on x86_64-linux. --- .../gdb.base/unwind-on-each-insn-amd64-2.exp | 11 +++++++++-- gdb/testsuite/gdb.base/unwind-on-each-insn-amd64.exp | 8 ++++++-- gdb/testsuite/gdb.base/unwind-on-each-insn-i386.exp | 8 ++++++-- gdb/testsuite/gdb.base/unwind-on-each-insn.exp | 1 + gdb/testsuite/gdb.base/unwind-on-each-insn.exp.tcl | 2 +- 5 files changed, 23 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/gdb.base/unwind-on-each-insn-amd64-2.exp b/gdb/testsuite/gdb.base/unwind-on-each-insn-amd64-2.exp index c8a94ccef4f..8675ba2fa48 100644 --- a/gdb/testsuite/gdb.base/unwind-on-each-insn-amd64-2.exp +++ b/gdb/testsuite/gdb.base/unwind-on-each-insn-amd64-2.exp @@ -17,8 +17,15 @@ require is_x86_64_m64_target -set srcfile_flags {debug} -set srcfile2_flags {nodebug} +set srcfile_flags {} +lappend srcfile_flags debug +lappend srcfile_flags nopie + +set srcfile2_flags {} +lappend srcfile2_flags nodebug +lappend srcfile_flags nopie + +set ldflags $srcfile_flags if [info exists COMPILE] { # Make sure that we use .eh_frame info, by generating it diff --git a/gdb/testsuite/gdb.base/unwind-on-each-insn-amd64.exp b/gdb/testsuite/gdb.base/unwind-on-each-insn-amd64.exp index cec4a2de236..e7c22d47cd7 100644 --- a/gdb/testsuite/gdb.base/unwind-on-each-insn-amd64.exp +++ b/gdb/testsuite/gdb.base/unwind-on-each-insn-amd64.exp @@ -17,8 +17,12 @@ require is_x86_64_m64_target -set srcfile_flags {debug} -set srcfile2_flags {debug} +set srcfile_flags {} +lappend srcfile_flags debug +lappend srcfile_flags nopie + +set srcfile2_flags $srcfile_flags +set ldflags $srcfile_flags if [info exists COMPILE] { standard_testfile unwind-on-each-insn.c unwind-on-each-insn-foo.c diff --git a/gdb/testsuite/gdb.base/unwind-on-each-insn-i386.exp b/gdb/testsuite/gdb.base/unwind-on-each-insn-i386.exp index 5e9f60902e7..255ed09f1ba 100644 --- a/gdb/testsuite/gdb.base/unwind-on-each-insn-i386.exp +++ b/gdb/testsuite/gdb.base/unwind-on-each-insn-i386.exp @@ -17,8 +17,12 @@ require is_x86_like_target -set srcfile_flags {debug} -set srcfile2_flags {debug} +set srcfile_flags {} +lappend srcfile_flags debug +lappend srcfile_flags nopie + +set srcfile2_flags $srcfile_flags +set ldflags $srcfile_flags if [info exists COMPILE] { standard_testfile unwind-on-each-insn.c unwind-on-each-insn-foo.c diff --git a/gdb/testsuite/gdb.base/unwind-on-each-insn.exp b/gdb/testsuite/gdb.base/unwind-on-each-insn.exp index 2fc6d30b0f3..b5fc257b69e 100644 --- a/gdb/testsuite/gdb.base/unwind-on-each-insn.exp +++ b/gdb/testsuite/gdb.base/unwind-on-each-insn.exp @@ -17,6 +17,7 @@ standard_testfile .c -foo.c set srcfile_flags {debug} set srcfile2_flags {nodebug} +set ldflags {debug} # Make sure that we don't use .eh_frame info, by not generating it, # using -fno-asynchronous-unwind-tables, if supported. diff --git a/gdb/testsuite/gdb.base/unwind-on-each-insn.exp.tcl b/gdb/testsuite/gdb.base/unwind-on-each-insn.exp.tcl index 1b6840e3102..82404d191e0 100644 --- a/gdb/testsuite/gdb.base/unwind-on-each-insn.exp.tcl +++ b/gdb/testsuite/gdb.base/unwind-on-each-insn.exp.tcl @@ -24,7 +24,7 @@ # value, can be calculated correctly. if {[prepare_for_testing_full "failed to prepare" \ - [list ${testfile} {debug} \ + [list ${testfile} $ldflags \ $srcfile $srcfile_flags $srcfile2 $srcfile2_flags]]} { return -1 } base-commit: 5f22c5abdc68b8a6eab049a30412511b941f65d8 -- 2.35.3