From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Support the NO_COLOR environment variable
Date: Mon, 25 Sep 2023 17:19:00 -0700 [thread overview]
Message-ID: <20230925171900.72d7d3e4@f37-zws-nv> (raw)
In-Reply-To: <20230925195751.1120801-1-tom@tromey.com>
On Mon, 25 Sep 2023 13:57:51 -0600
Tom Tromey <tom@tromey.com> wrote:
> I ran across this site:
>
> https://no-color.org/
>
> ... which lobbies for tools to recognize the NO_COLOR environment
> variable and disable any terminal styling when it is seen.
>
> This patch implements this for gdb.
>
> Regression tested on x86-64 Fedora 38.
>
> Co-Authored-By: Andrew Burgess <aburgess@redhat.com>
LGTM.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2023-09-26 0:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 19:57 Tom Tromey
2023-09-26 0:19 ` Kevin Buettner via Gdb-patches [this message]
2023-09-26 2:29 ` Eli Zaretskii via Gdb-patches
2023-09-26 13:50 ` Andrew Burgess via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925171900.72d7d3e4@f37-zws-nv \
--to=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox