From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6AKMCDjvDGU2kxoAWB0awg (envelope-from ) for ; Thu, 21 Sep 2023 21:34:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=EFY1WQGA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 19DF21E0C3; Thu, 21 Sep 2023 21:34:48 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 098961E028 for ; Thu, 21 Sep 2023 21:34:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 505A63858402 for ; Fri, 22 Sep 2023 01:34:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 505A63858402 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695346485; bh=59PoB4GSkCNptQfdGriArm2nAFfR4m/RtO6jzRHgyDU=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=EFY1WQGAsjmnfg5wnwhaJLA2khRpel9/urUswlNedLS44FK37vZZd+10au+sDW8Yx I+YlCHEaC0gKyReHSZQC0ZHI6DvHAxX+j/py3tzh/q5SF/wBpgsKo7dH14YUyuPxaU gCW9j3qnnndCeVMTF+pT/3l0d5c3ODBkX9x3KODw= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 043C13858C27 for ; Fri, 22 Sep 2023 01:34:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 043C13858C27 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-212-Qk9kOyjHP9qzF_r9KvXkuA-1; Thu, 21 Sep 2023 21:34:22 -0400 X-MC-Unique: Qk9kOyjHP9qzF_r9KvXkuA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A7F363800A17; Fri, 22 Sep 2023 01:34:21 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.32.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E869C15BB8; Fri, 22 Sep 2023 01:34:21 +0000 (UTC) Date: Thu, 21 Sep 2023 18:34:19 -0700 To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Remove keywords from target debug printer names Message-ID: <20230921183419.42e94c7c@f37-zws-nv> In-Reply-To: <20230919170534.3918313-1-tromey@adacore.com> References: <20230919170534.3918313-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, 19 Sep 2023 11:05:34 -0600 Tom Tromey via Gdb-patches wrote: > I recently checked in a patch that removed the use of the "struct" > keyword in some spots. Doing this pointed out that the target > delegate code preserves this keyword -- but, with C++, it does not > really need to. This patch changes make-target-delegates.py to remove > these keywords, and updates target-debug.h to follow. This pointed > out that there was already one redudancy: both > target_debug_print_struct_inferior_p and target_debug_print_inferior_p > existed. > > Tested by rebuilding. LGTM. Reviewed-by: Kevin Buettner