From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Fp0MLDWgCWUuIxkAWB0awg (envelope-from ) for ; Tue, 19 Sep 2023 09:20:53 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=rvgz4n39; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A9CB21E0C3; Tue, 19 Sep 2023 09:20:53 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 97D781E092 for ; Tue, 19 Sep 2023 09:20:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B8DAB3856975 for ; Tue, 19 Sep 2023 13:20:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B8DAB3856975 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695129650; bh=pkKlk7q20YlA4dHFOMlnyu7QIY0oQHsku/239tlee+s=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=rvgz4n39z6ZLz+RF/j1WeuG7t3OxViGlcCDjgOF50F5QMW1LZxfjNi+yZfBWmnZHm AEaDV0KuOM4vBmyNv/Hpo5FvjkR/cYZJEzL42j95/Oju4tb+b0T6qwNFI8KSofSmUm ZXEnrzgkL+gmD0ptDdDvRUNy+g+AVwq86Es1Eqf0= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 1F6553856DF4 for ; Tue, 19 Sep 2023 13:20:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F6553856DF4 Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 9965D813EC; Tue, 19 Sep 2023 13:20:28 +0000 (UTC) Date: Tue, 19 Sep 2023 14:20:23 +0100 To: "Ijaz, Abdul B" Cc: "gdb-patches@sourceware.org" , "pedro@palves.net" Subject: Re: [PATCH v3 2/2] gdb: add shadowed field in '-stack-list-locals/variables' mi commands Message-ID: <20230919132023.3bd56n7v3x7hgsph@octopus> References: <20230918164738.17082-1-abdul.b.ijaz@intel.com> <20230918164738.17082-3-abdul.b.ijaz@intel.com> <20230918225323.n526b3ubkkzvzsbe@octopus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Tue, 19 Sep 2023 13:20:28 +0000 (UTC) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, Sep 19, 2023 at 11:41:47AM +0000, Ijaz, Abdul B wrote: > Hi Lancelot, > > Thanks for the feedback, will apply the changes similar to previous patch in V4 Patch series and will use " ("shadowed", "True");" to be consistent with other fields. > Hi, I was not sure if "True" or "true" should be used. Looking around (with `git grep "field_string" | grep -i true` show that "true" is usualy used (see gdb/mi/mi-cmd-var.c and gdb/mi/mi-cmd-info.c). Best, Lancelot.