From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oELEEmpkCGV6hhgAWB0awg (envelope-from ) for ; Mon, 18 Sep 2023 10:53:30 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=kJ5sL+6y; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4A2D61E0C3; Mon, 18 Sep 2023 10:53:30 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 391EC1E028 for ; Mon, 18 Sep 2023 10:53:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B9AAB385B51F for ; Mon, 18 Sep 2023 14:53:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B9AAB385B51F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695048807; bh=tzjEPgUZ/00SBYU0PwZOOjx+ZTWTB35CTNUP0Lhm0ug=; h=Subject:Date:To:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=kJ5sL+6y+JJsNp7QM6k0VxldmYd6aseNW1xDCjoGyOHym/cYvh3jmMvvb5F8YDx3V /hdEhFhot0dlBrxA8SNGf1khfoRZAzyL/CXVogXa48dcAnHmo4M7RGtM1vinCxzCyk s6pI+DE42C2UdgfyQ4aFxj2smEM7y3cGWxqs6Dy0= Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 0DDCA3858C50 for ; Mon, 18 Sep 2023 14:52:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DDCA3858C50 Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-34e25ad38cbso13923385ab.1 for ; Mon, 18 Sep 2023 07:52:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695048767; x=1695653567; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tzjEPgUZ/00SBYU0PwZOOjx+ZTWTB35CTNUP0Lhm0ug=; b=ER65Uz21q2xKJKN9DARL36caQ8+p0P+wB71jN6THkwn6EyWRt/GuWeEPK92JExOXeP meDhkhnDEIaQXWiDpwaE5WpEx64Btt/NrOU3ul/oI1J8kH+0gLxojn2YkS6yVd0Jalzg oJNC4RwZhU6fKnCoIOKHyPUL2L/ii6bUlXBsWKPlbZkGep7lXcfSRDbApeKr9+yheaXZ AJX7KPEuAzLRu9FgAUDrAcehzy6XJ/BbJxRPgaxIsE/5Xm2WxRax54Jxc31O67ulg/sN hFJ9U80RAYDT4mwLpiSHms1Dkk37gLyEdeYpSkE+IOMzfpcp9mDyt2iGUbNjw7YomaCq QEmg== X-Gm-Message-State: AOJu0YyAZiyxTOdERWsHFOdML8amY0tEo5Ztri8AzUHxjowJX8gPU1zD VdeVfDOKZq8FKHzN1ngd9qgDpw== X-Google-Smtp-Source: AGHT+IGXdeN78rQzOeSl0jzntYTi+VNHbD/4kqsoTtJ7BByJSbFCFr/dYD4oGL7uVVwybnypNe0kJA== X-Received: by 2002:a92:605:0:b0:34f:41ba:7c87 with SMTP id x5-20020a920605000000b0034f41ba7c87mr9784014ilg.4.1695048767370; Mon, 18 Sep 2023 07:52:47 -0700 (PDT) Received: from localhost.localdomain (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id v19-20020a056e020f9300b0034f65b28335sm2359256ilo.66.2023.09.18.07.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 07:52:47 -0700 (PDT) Subject: [PATCH v2 0/7] Rewrite gdb_bfd_openr_iovec to be type-safe Date: Mon, 18 Sep 2023 08:52:45 -0600 Message-Id: <20230918-gdb-bfd-vec-v2-0-162c0e9a2bc9@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAD1kCGUC/22NQQ6DIBBFr2Jm3WkAbdWueo/GxQCjslAaMKSN4 e5F112+5P33d4gcHEd4VDsETi46vxZQlwrMTOvE6GxhUELVolMNTlajHi0mNqipHe9GyrrXGsr iHXh0n7P2Ggpriow60Grmo7FQ3Dgc4uzi5sP3fE3y0P8fJIkCu5vghnvRspVPsmR84KvxCww55 x/2oc1owQAAAA== To: gdb-patches@sourceware.org Cc: Lancelot Six X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom Tromey via Gdb-patches Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This series rewrites gdb_bfd_openr_iovec to be type-safe. Note that I can't really test the solib-rocm.c changes, this was done as a best effort. Regression tested on x86-64 Fedora 36. --- Changes in v2: - Use static_cast - Applied fix to the rocm patch - Link to v1: https://inbox.sourceware.org/gdb-patches/20230824-gdb-bfd-vec-v1-0-850e4e907ed1@adacore.com --- Tom Tromey (7): Introduce type-safe variant of gdb_bfd_openr_iovec Small constructor change to target_buffer Convert mem_bfd_iovec to new type-safe gdb_bfd_openr_iovec Convert target fileio to new type-safe gdb_bfd_openr_iovec Convert minidebug to new type-safe gdb_bfd_openr_iovec Convert solib-rocm to new type-safe gdb_bfd_openr_iovec Remove old gdb_bfd_openr_iovec gdb/gdb_bfd.c | 211 +++++++++++++++++++++++++++---------------------------- gdb/gdb_bfd.h | 43 ++++++++---- gdb/minidebug.c | 98 +++++++++++--------------- gdb/solib-rocm.c | 66 +++++------------ 4 files changed, 191 insertions(+), 227 deletions(-) --- base-commit: cf2ab5ef0b716dea512d85276c484fce758fa5d4 change-id: 20230824-gdb-bfd-vec-ba7f6c1139bb Best regards, -- Tom Tromey