From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PGJHLbGSBGUuyBYAWB0awg (envelope-from ) for ; Fri, 15 Sep 2023 13:21:53 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=S3vUY7UT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B02FF1E0C3; Fri, 15 Sep 2023 13:21:53 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A06971E092 for ; Fri, 15 Sep 2023 13:21:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A0F03858C54 for ; Fri, 15 Sep 2023 17:21:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A0F03858C54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694798511; bh=YbdJgNBsUgQYUYjTexxkJT9amtOwarsC+AFAOjism8o=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=S3vUY7UTiMO6XCjMURZG2oIzWuM1mOhulNrq2aOXmaavryFvbmJpp/t2izJ9Ey3SF hs6cu74qD+o3ENeU0COQpqxcYCJrzhr9Q5WoLHh+Hin2+PwoF4e8HcL1anzjxz9GHl WQxzpFv0gr7NxoROUIfZ8VMEQvz+Ir0dJNnnBZYw= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 7BE373858D35 for ; Fri, 15 Sep 2023 17:21:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BE373858D35 Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 5BC1F80910; Fri, 15 Sep 2023 17:21:28 +0000 (UTC) Date: Fri, 15 Sep 2023 18:19:55 +0100 To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 2/3] gdb/testsuite: add linux target check in allow_hipcc_tests Message-ID: <20230915171955.x5azvjkeavyydjls@octopus> References: <20230915145249.22318-1-simon.marchi@efficios.com> <20230915145249.22318-2-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230915145249.22318-2-simon.marchi@efficios.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Fri, 15 Sep 2023 17:21:28 +0000 (UTC) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Fri, Sep 15, 2023 at 10:52:12AM -0400, Simon Marchi via Gdb-patches wrote: > ROCm / HIP tests should only run on Linux for now, existing gdb.rocm > tests miss such a check. Add an "istarget linux" check in > allow_hipcc_tests. > > Change-Id: I71f69e510a754f2fdadc32de53b923ebb9835ab5 > --- > gdb/testsuite/lib/rocm.exp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp > index 98a3b308228d..791f1b403bb7 100644 > --- a/gdb/testsuite/lib/rocm.exp > +++ b/gdb/testsuite/lib/rocm.exp > @@ -67,6 +67,10 @@ gdb_caching_proc allow_hipcc_tests {} { > return {0 "remote debugging"} > } > > + if {![istarget "*-linux*"]} { > + return {0 "target platform is not Linux"} > + } > + Hi, This looks good to me. As this is a rocm-specific part, I think I can now add: Approved-By: Lancelot Six Thanks, Lancelot. > # Ensure that GDB is built with amd-dbgapi support. > set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"] > if { [string first "--with-amd-dbgapi" $output] == -1 } { > -- > 2.42.0 >