From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +RKFIfzOBGXe6RYAWB0awg (envelope-from ) for ; Fri, 15 Sep 2023 17:39:08 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=gMcD5HDc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 800F61E0C3; Fri, 15 Sep 2023 17:39:08 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 703271E092 for ; Fri, 15 Sep 2023 17:39:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D08D13858C00 for ; Fri, 15 Sep 2023 21:39:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D08D13858C00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694813945; bh=YjeWlaq9oGoYFZfeCiD/wOGe8biEfGTP//gVoyfACaA=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=gMcD5HDcQXl9v5umwGiGpRdQui4jc34umwUWiN/TcYf+qOmWlMQFXkCT+7XCkv/ld g38rMYXD2+FJGrZh1O07CdU6zzkwJo84t1jEz/tlnAqbS0NRvpfdPcm3BVVtAAJQ49 ZvXONhdsa9+fyU578NLSgP5A8xQ4+RaGo332xWMs= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B7EA23858C52 for ; Fri, 15 Sep 2023 21:38:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7EA23858C52 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-319-XlamS0g3O46XMOoItcr1yw-1; Fri, 15 Sep 2023 17:38:42 -0400 X-MC-Unique: XlamS0g3O46XMOoItcr1yw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C8D3101B048; Fri, 15 Sep 2023 21:38:41 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.32.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4AFF8200BFE3; Fri, 15 Sep 2023 21:38:41 +0000 (UTC) Date: Fri, 15 Sep 2023 14:38:39 -0700 To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/symtab] Fix overly large gdb-index file check for 32-bit Message-ID: <20230915143839.577e6a86@f37-zws-nv> In-Reply-To: <20230915090837.16945-1-tdevries@suse.de> References: <20230915090837.16945-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Fri, 15 Sep 2023 11:08:37 +0200 Tom de Vries wrote: > Add a unit test which checks that write_gdb_index_1 will throw > an error when the size of the file would exceed the maximum value > capable of being represented by 'offset_type'. > > The unit test fails on 32-bit systems due to wrapping overflow. Fix this by > changing the type of total_len in write_gdbindex_1 from size_t to uint64_t. > > Tested on x86_64-linux. > > Co-Authored-By: Kevin Buettner > --- > gdb/dwarf2/index-write.c | 84 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 82 insertions(+), 2 deletions(-) Thanks for adding the additional test along with fixing the wrapping overflow problem on 32-bit systems. Approved-by: Kevin Buettner