From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: "Ijaz, Abdul B via Gdb-patches" <gdb-patches@sourceware.org>
Cc: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>,
"tom@tromey.com" <tom@tromey.com>
Subject: Re: [PING 6][PATCH v2 0/4] Adapt Fortran testsuite for ifort
Date: Tue, 5 Sep 2023 19:10:28 -0700 [thread overview]
Message-ID: <20230905191028.40239535@f37-zws-nv> (raw)
In-Reply-To: <SA1PR11MB6846CF0A7EC4299C28B91C8ECBEAA@SA1PR11MB6846.namprd11.prod.outlook.com>
Hi Abdul,
Tom had some comments on patch 3, but said that the rest looked
good. See:
https://sourceware.org/pipermail/gdb-patches/2022-August/191607.html
I've looked over the patch 3 from the v2 series (in which you
addressed Tom's concern). It looks good to me.
Therefore...
Approved-by: Kevin Buettner <kevinb@redhat.com>
On Sun, 3 Sep 2023 19:11:12 +0000
"Ijaz, Abdul B via Gdb-patches" <gdb-patches@sourceware.org> wrote:
> Ping!
>
> Thanks,
> Abdul Basit
> ________________________________________
> From: Kempke, Nils-Christian <mailto:nils-christian.kempke@intel.com>
> Sent: Fri Oct 21, 2022 08:15:08 GMT 2022
> To: mailto:gdb-patches@sourceware.org <mailto:gdb-patches@sourceware.org>; Kempke, Nils-Christian <mailto:nils-christian.kempke@intel.com>
> Cc: mailto:tom@tromey.com <mailto:tom@tromey.com>
> Subject: Re: [PING 5][PATCH v2 0/4] Adapt Fortran testsuite for ifort
> Ping!
>
> Thanks,
> Nils
> ________________________________
> From: Kempke, Nils-Christian <mailto:nils-christian.kempke@intel.com>
> Sent: Thursday, October 13, 2022 10:52 AM
> To: mailto:gdb-patches@sourceware.org <mailto:gdb-patches@sourceware.org>; Kempke, Nils-Christian <mailto:nils-christian.kempke@intel.com>
> Cc: mailto:tom@tromey.com <mailto:tom@tromey.com>
> Subject: Re: [PING 4][PATCH v2 0/4] Adapt Fortran testsuite for ifort
>
> Ping!
>
> Thanks,
> Nils
>
> ________________________________
> From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=mailto:intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <mailto:gdb-patches@sourceware.org>
> Sent: Wednesday, October 5, 2022 10:23 PM
> To: mailto:gdb-patches@sourceware.org <mailto:gdb-patches@sourceware.org>
> Cc: mailto:tom@tromey.com <mailto:tom@tromey.com>
> Subject: Re: [PING 3][PATCH v2 0/4] Adapt Fortran testsuite for ifort
>
> Ping!
>
> Thanks,
> Nils
> ________________________________
> From: Kempke, Nils-Christian <mailto:nils-christian.kempke@intel.com>
> Sent: Monday, September 26, 2022 4:02 PM
> To: mailto:gdb-patches@sourceware.org <mailto:gdb-patches@sourceware.org>; Kempke, Nils-Christian <mailto:nils-christian.kempke@intel.com>
> Cc: mailto:tom@tromey.com <mailto:tom@tromey.com>
> Subject: Re: [PING 2][PATCH v2 0/4] Adapt Fortran testsuite for ifort
>
> Ping!
>
> Thanks,
> Nils
> ________________________________
> From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=mailto:intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <mailto:gdb-patches@sourceware.org>
> Sent: Monday, September 19, 2022 12:18 PM
> To: mailto:gdb-patches@sourceware.org <mailto:gdb-patches@sourceware.org>
> Cc: mailto:tom@tromey.com <mailto:tom@tromey.com>
> Subject: Re: [PING][PATCH v2 0/4] Adapt Fortran testsuite for ifort
>
> Ping!
>
> Thanks,
> Nils
> ________________________________
> From: Kempke, Nils-Christian <mailto:nils-christian.kempke@intel.com>
> Sent: Wednesday, August 31, 2022 11:36 AM
> To: mailto:gdb-patches@sourceware.org <mailto:gdb-patches@sourceware.org>
> Cc: mailto:tom@tromey.com <mailto:tom@tromey.com>; Kempke, Nils-Christian <mailto:nils-christian.kempke@intel.com>
> Subject: [PATCH v2 0/4] Adapt Fortran testsuite for ifort
>
> Hi!
>
> Please find attached v2 of this series.
>
> V1 can be found here:
>
> https://sourceware.org/pipermail/gdb-patches/2022-June/190013.html
>
> V2 incorporates Tom's comment on patch 3/4 here:
>
> https://sourceware.org/pipermail/gdb-patches/2022-August/191606.html
>
> so changes from v1 to v2 only concern patch 3:
>
> * Patch 1: unchanged.
> * Patch 2: unchanged.
> * Patch 3: Remove fortran_runto_main for the two tests as well as the
> first breakpoint setting + hitting and instead use runto to directly
> run to the first breakpoint location.
> * Patch 4: unchanged.
>
> Tom has approved of Patch 1, 2, and 4 otherwise, but if anyone has a
> comment, they are always welcome!
>
> Cheers!
> Nils
>
> Nils-Christian Kempke (4):
> testsuite, fortran: make mixed-lang-stack less compiler dependent
> testsuite, fortran: Remove self assignment non-statements
> testsuite, fortran: adapt tests for ifort's 'start' behavior
> testsuite, fortran: make kfail gfortran specific
>
> gdb/testsuite/gdb.fortran/array-slices-bad.exp | 13 +++++--------
> gdb/testsuite/gdb.fortran/function-calls.exp | 4 +++-
> gdb/testsuite/gdb.fortran/library-module-lib.f90 | 2 +-
> gdb/testsuite/gdb.fortran/library-module-main.f90 | 2 +-
> gdb/testsuite/gdb.fortran/mixed-lang-stack.exp | 9 ++++++++-
> gdb/testsuite/gdb.fortran/module.f90 | 11 ++++++-----
> gdb/testsuite/gdb.fortran/vla-type.exp | 11 +++--------
> 7 files changed, 27 insertions(+), 25 deletions(-)
>
> --
> 2.25.1
>
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2023-09-06 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 19:11 Ijaz, Abdul B via Gdb-patches
2023-09-06 2:10 ` Kevin Buettner via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905191028.40239535@f37-zws-nv \
--to=gdb-patches@sourceware.org \
--cc=abdul.b.ijaz@intel.com \
--cc=kevinb@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox