From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Feiyang Chen <chenfeiyang@loongson.cn>,
chris.chenfeiyang@gmail.com, Huacai Chen <chenhuacai@kernel.org>,
gdb-patches@sourceware.org, Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH v2] gdb: LoongArch: Support LBT registers
Date: Thu, 31 Aug 2023 09:05:22 -0700 [thread overview]
Message-ID: <20230831090522.68183782@f37-zws-nv> (raw)
In-Reply-To: <20230831120050.3878201-1-zhoubinbin@loongson.cn>
On Thu, 31 Aug 2023 20:00:50 +0800
Binbin Zhou <zhoubinbin@loongson.cn> wrote:
> From: Feiyang Chen <chenfeiyang@loongson.cn>
>
> Add LBT registers ($scrx, $eflags, $ftop) support for LoongArch.
>
> Co-authored-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
> v2:
> Thanks to Kevin for his suggestion.
> 1. Rename LOONGARCH_SCR_REGNUM to LOONGARCH_LAST_SCR_REGNUM for better understanding;
> 2. Format the code so that a line of source code will not be exceeding 80 characters;
> 3. Change NT_LOONGARCH_LBT to NT_LARCH_LBT.
>
> Link to V1:
> https://inbox.sourceware.org/gdb-patches/20230825101113.3527944-1-chenfeiyang@loongson.cn/
Move the Co-authored-by tag towards the bottom of the commit message.
Aside, from that, it looks good to me.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2023-08-31 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 12:00 Binbin Zhou
2023-08-31 16:05 ` Kevin Buettner via Gdb-patches [this message]
2023-09-07 11:31 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831090522.68183782@f37-zws-nv \
--to=gdb-patches@sourceware.org \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=kevinb@redhat.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox