Re: [PATCH] [gdb/build] Fix C inclusion of nat/x86-cpuid.h

John Baldwin
2023-08-29T15:54:13Z

On 8/29/23 8:38 AM, Tom de Vries via Gdb-patches wrote:
> When running test-case gdb.arch/i386-avx512.exp, I run into:
> ...
> gdb compile failed, In file included from gdb.arch/i386-avx512.c:20:0:
> src/gdb/nat/x86-cpuid.h: In function 'x86_cpuid_count':
> src/gdb/nat/x86-cpuid.h:63:16: error: \
> 'nullptr' undeclared (first use in this function)
> if (__eax == nullptr)
> ^~~~~~~
> src/gdb/nat/x86-cpuid.h:63:16: note: each \
> undeclared identifier is reported only once for each function it appears in
>
> === gdb Summary ===
>
> # of untested testcases 1
> ...
>
> This is due to commit e85aad4ae76 ("nat/x86-cpuid.h: Add x86_cpuid_count
> wrapper around __get_cpuid_count"), which introduced the nullptr check.
>
> The header file gdb/nat/x86-cpuid.h is a file that is included in the build
> and compiled as a C++ file, but also in the testsuite and compiled as a C
> file.
>
> Fix this by replacing nullptr with (void *)0.
>
> Tested on x86_64-linux.

This seems obvious to me, please push.

--
John Baldwin