From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Use get_frame_address_in_block in print_frame
Date: Fri, 25 Aug 2023 19:33:17 -0700 [thread overview]
Message-ID: <20230825193317.698943d7@f37-zws-nv> (raw)
In-Reply-To: <20230804173635.392319-1-tom@tromey.com>
On Fri, 4 Aug 2023 11:36:35 -0600
Tom Tromey <tom@tromey.com> wrote:
> The author of 'mold' pointed out that with a certain shared library,
> gdb would fail to find the shared library's name in 'bt'.
>
> The function in question appeared at the end of the .so's .text
> segment and ended with a call to 'abort'.
>
> This turned out to be a classic case of calling get_frame_pc when
> get_frame_address_in_block is needed -- the former will be off-by-one
> for purposes of finding the enclosing function or shared library.
>
> The included test fails without the patch on my system. However, I
> imagine it can't be assumed to reliably fail. Nevertheless it seemed
> worth doing.
>
> Regression tested on x86-64 Fedora 38.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29074
LGTM.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
prev parent reply other threads:[~2023-08-26 2:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 17:36 Tom Tromey
2023-08-26 2:33 ` Kevin Buettner via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825193317.698943d7@f37-zws-nv \
--to=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox